Fix InputConnection.deleteSurroundingText()

third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/InputMethodController.h"
 
 #include "core/dom/Element.h"
 #include "core/dom/Range.h"
 #include "core/editing/FrameSelection.h"
 #include "core/frame/LocalFrame.h"
@@ skipping 172 matching lines @@
         insertHTMLElement("<input id='sample' type='password' size='24'>", "sample"));
 
     Vector<CompositionUnderline> underlines;
     underlines.append(CompositionUnderline(0, 5, Color(255, 0, 0), false, 0));
     controller().setComposition("foo", underlines, 0, 3);
     controller().confirmComposition();
 
     EXPECT_STREQ("foo", input->value().utf8().data());
 }
 
+TEST_F(InputMethodControllerTest, DeleteSurroundingTextWithEmptyText)
+{
+    HTMLInputElement* input = toHTMLInputElement(
+        insertHTMLElement("<input id='sample'>", "sample"));
+
+    input->setValue("");
+    EXPECT_STREQ("", input->value().utf8().data());
+    controller().deleteSurroundingText(0, 0);
+    EXPECT_STREQ("", input->value().utf8().data());
+
+    input->setValue("");
+    EXPECT_STREQ("", input->value().utf8().data());
+    controller().deleteSurroundingText(1, 0);
+    EXPECT_STREQ("", input->value().utf8().data());
+
+    input->setValue("");
+    EXPECT_STREQ("", input->value().utf8().data());
+    controller().deleteSurroundingText(0, 1);
+    EXPECT_STREQ("", input->value().utf8().data());
+}
+
+TEST_F(InputMethodControllerTest, DeleteSurroundingTextWithRangeSelection)
+{
+    HTMLInputElement* input = toHTMLInputElement(
+        insertHTMLElement("<input id='sample'>", "sample"));
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(1, 4));
+    controller().deleteSurroundingText(0, 0);
+    EXPECT_STREQ("hello", input->value().utf8().data());
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(1, 4));
+    controller().deleteSurroundingText(1, 1);
+    EXPECT_STREQ("ell", input->value().utf8().data());
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(1, 4));
+    controller().deleteSurroundingText(100, 0);
+    EXPECT_STREQ("ello", input->value().utf8().data());
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(1, 4));
+    controller().deleteSurroundingText(0, 100);
+    EXPECT_STREQ("hell", input->value().utf8().data());
+}
+
+TEST_F(InputMethodControllerTest, DeleteSurroundingTextWithCursorSelection)
+{
+    HTMLInputElement* input = toHTMLInputElement(
+        insertHTMLElement("<input id='sample'>", "sample"));
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(2, 2));
+    controller().deleteSurroundingText(0, 0);
+    EXPECT_STREQ("hello", input->value().utf8().data());
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(2, 2));
+    controller().deleteSurroundingText(1, 1);
+    EXPECT_STREQ("hlo", input->value().utf8().data());
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(2, 2));
+    controller().deleteSurroundingText(100, 0);
+    EXPECT_STREQ("llo", input->value().utf8().data());
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(2, 2));
+    controller().deleteSurroundingText(0, 100);
+    EXPECT_STREQ("he", input->value().utf8().data());
+}
+
+TEST_F(InputMethodControllerTest, DeleteSurroundingTextWithMultiCodeTextOnTheLeft)
+{
+    HTMLInputElement* input = toHTMLInputElement(
+        insertHTMLElement("<input id='sample'>", "sample"));
+
+    // U+2605 == "black star". It takes up 1 space.
+    input->setValue(String::fromUTF8("foo\xE2\x98\x85"));
+    controller().setEditableSelectionOffsets(PlainTextRange(4, 4));
+    EXPECT_STREQ("foo\xE2\x98\x85", input->value().utf8().data());
+    controller().deleteSurroundingText(1, 0);
+    EXPECT_STREQ("foo", input->value().utf8().data());
+
+    // U+1F3C6 == "trophy". It takes up 2 space.
+    input->setValue(String::fromUTF8("foo\xF0\x9F\x8F\x86"));
+    controller().setEditableSelectionOffsets(PlainTextRange(5, 5));
+    EXPECT_STREQ("foo\xF0\x9F\x8F\x86", input->value().utf8().data());
+    controller().deleteSurroundingText(1, 0);
+    EXPECT_STREQ("foo", input->value().utf8().data());
+
+    // composed U+0E01 "ka kai" + U+0E49 "mai tho". It takes up 2 space.
+    input->setValue(String::fromUTF8("foo\xE0\xB8\x81\xE0\xB9\x89"));
+    controller().setEditableSelectionOffsets(PlainTextRange(5, 5));
+    EXPECT_STREQ("foo\xE0\xB8\x81\xE0\xB9\x89", input->value().utf8().data());
+    controller().deleteSurroundingText(1, 0);
+    EXPECT_STREQ("foo", input->value().utf8().data());
+
+    // "trophy" + "trophy".
+    input->setValue(String::fromUTF8("foo\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86"));
+    controller().setEditableSelectionOffsets(PlainTextRange(7, 7));
+    EXPECT_STREQ("foo\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86", input->value().utf8().data());
+    controller().deleteSurroundingText(2, 0);
+    EXPECT_STREQ("foo\xF0\x9F\x8F\x86", input->value().utf8().data());
+
+    // "trophy" + "trophy".
+    input->setValue(String::fromUTF8("foo\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86"));
+    controller().setEditableSelectionOffsets(PlainTextRange(7, 7));
+    EXPECT_STREQ("foo\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86", input->value().utf8().data());
+    controller().deleteSurroundingText(3, 0);
+    EXPECT_STREQ("foo", input->value().utf8().data());
+
+    // "trophy" + "trophy".
+    input->setValue(String::fromUTF8("foo\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86"));
+    controller().setEditableSelectionOffsets(PlainTextRange(7, 7));
+    EXPECT_STREQ("foo\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86", input->value().utf8().data());
+    controller().deleteSurroundingText(4, 0);
+    EXPECT_STREQ("foo", input->value().utf8().data());
+
+    // "trophy" + "trophy".
+    input->setValue(String::fromUTF8("foo\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86"));
+    controller().setEditableSelectionOffsets(PlainTextRange(7, 7));
+    EXPECT_STREQ("foo\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86", input->value().utf8().data());
+    controller().deleteSurroundingText(5, 0);
+    EXPECT_STREQ("fo", input->value().utf8().data());
+}
+
+TEST_F(InputMethodControllerTest, DeleteSurroundingTextWithMultiCodeTextOnTheRight)
+{
+    HTMLInputElement* input = toHTMLInputElement(
+        insertHTMLElement("<input id='sample'>", "sample"));
+
+    // U+2605 == "black star". It takes up 1 space.
+    input->setValue(String::fromUTF8("\xE2\x98\x85 foo"));
+    controller().setEditableSelectionOffsets(PlainTextRange(0, 0));
+    EXPECT_STREQ("\xE2\x98\x85 foo", input->value().utf8().data());
+    controller().deleteSurroundingText(0, 1);
+    EXPECT_STREQ(" foo", input->value().utf8().data());
+
+    // U+1F3C6 == "trophy". It takes up 2 space.
+    input->setValue(String::fromUTF8("\xF0\x9F\x8F\x86 foo"));
+    controller().setEditableSelectionOffsets(PlainTextRange(0, 0));
+    EXPECT_STREQ("\xF0\x9F\x8F\x86 foo", input->value().utf8().data());
+    controller().deleteSurroundingText(0, 1);
+    EXPECT_STREQ(" foo", input->value().utf8().data());
+
+    // composed U+0E01 "ka kai" + U+0E49 "mai tho". It takes up 2 space.
+    input->setValue(String::fromUTF8("\xE0\xB8\x81\xE0\xB9\x89 foo"));
+    controller().setEditableSelectionOffsets(PlainTextRange(0, 0));
+    EXPECT_STREQ("\xE0\xB8\x81\xE0\xB9\x89 foo", input->value().utf8().data());
+    controller().deleteSurroundingText(0, 1);
+    EXPECT_STREQ(" foo", input->value().utf8().data());
+
+    // "trophy" + "trophy".

[yosin_UTC9, 2016/04/26 08:18:54]

Are below tests handle grapheme clusters?
+nona@ for emoji expert.

[Seigo Nonaka, 2016/04/26 08:48:39]

Looks like this is the case that the IME specifies invalid surrogate pair
boundary. Looks like following four test cases are reasonable to me.
API spec says IME author should care about surrogate pair handling but it
doesn't mention about the behavior of Editor in that case.
http://developer.android.com/intl/ja/reference/android/view/inputmethod/Input...,
int)

Thus, it is make sense to remove the unpaired surrogate pair.
FWIW, it may be good if we can add a test case that removing unpaired leading
and trailing surrogate pairs, like deleteSurroundingText(1, 1) for "\uD83C
\uDFC6 | \uD83C \uDFC6" goes empty string.

// "trophy" + "trophy".
input->setValue(String::fromUTF8("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86 foo"));
controller().setEditableSelectionOffsets(PlainTextRange(2, 2));
EXPECT_STREQ("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86 foo",
input->value().utf8().data());
controller().deleteSurroundingText(1, 1);
EXPECT_STREQ(" foo", input->value().utf8().data());

For the grapheme cluster, I think as far as IME deletes a text by
InputConnection.deleteSurroundinText, IME should care about the grapheme
boundary since InputConnection.deleteSurroundingText only accepts in UTF16 code
unit and API spec doesn't say anything about grapheme clusters.

On the other hand, the backspace or forward delete keyevent should be cared by
editor.

+    input->setValue(String::fromUTF8("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86 foo"));
+    controller().setEditableSelectionOffsets(PlainTextRange(0, 0));
+    EXPECT_STREQ("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86 foo", input->value().utf8().data());
+    controller().deleteSurroundingText(0, 2);
+    EXPECT_STREQ("\xF0\x9F\x8F\x86 foo", input->value().utf8().data());
+
+    // "trophy" + "trophy".
+    input->setValue(String::fromUTF8("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86 foo"));
+    controller().setEditableSelectionOffsets(PlainTextRange(0, 0));
+    EXPECT_STREQ("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86 foo", input->value().utf8().data());
+    controller().deleteSurroundingText(0, 3);
+    EXPECT_STREQ(" foo", input->value().utf8().data());
+
+    // "trophy" + "trophy".
+    input->setValue(String::fromUTF8("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86 foo"));
+    controller().setEditableSelectionOffsets(PlainTextRange(0, 0));
+    EXPECT_STREQ("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86 foo", input->value().utf8().data());
+    controller().deleteSurroundingText(0, 4);
+    EXPECT_STREQ(" foo", input->value().utf8().data());
+
+    // "trophy" + "trophy".
+    input->setValue(String::fromUTF8("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86 foo"));
+    controller().setEditableSelectionOffsets(PlainTextRange(0, 0));
+    EXPECT_STREQ("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86 foo", input->value().utf8().data());
+    controller().deleteSurroundingText(0, 5);
+    EXPECT_STREQ("foo", input->value().utf8().data());
+}
+
 } // namespace blink