Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

Issue 1889053002: IntersectionObserver: notify when root or target is removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/IntersectionObserver.cpp
diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp b/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp
index 9b02dfaa69334d0293ec18ec095d601aa672d549..2204a46cf6920570d223359aa1f560aa4dca399d 100644
--- a/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp
+++ b/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp
@@ -194,8 +194,6 @@ void IntersectionObserver::unobserve(Element* target)
void IntersectionObserver::computeIntersectionObservations()
{
- if (!m_root || !m_root->inShadowIncludingDocument())
ojan 2016/04/15 18:19:08 Moving this makes me a bit sad because it means we
- return;
Document* callbackDocument = toDocument(m_callback->getExecutionContext());
if (!callbackDocument)
return;

Powered by Google App Engine
This is Rietveld 408576698