Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/intersection-observer/remove-element.html

Issue 1889053002: IntersectionObserver: notify when root or target is removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/intersection-observer/remove-element-expected.txt » ('j') | third_party/WebKit/Source/core/dom/IntersectionObservation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/intersection-observer/remove-element.html
diff --git a/third_party/WebKit/LayoutTests/intersection-observer/same-document-root.html b/third_party/WebKit/LayoutTests/intersection-observer/remove-element.html
similarity index 64%
copy from third_party/WebKit/LayoutTests/intersection-observer/same-document-root.html
copy to third_party/WebKit/LayoutTests/intersection-observer/remove-element.html
index 3c4cfe76f50915b1c25ed89b2da7874e1312f455..df0ed11617899d0b6d4c6a4fd07ebe7a26d85fe3 100644
--- a/third_party/WebKit/LayoutTests/intersection-observer/same-document-root.html
+++ b/third_party/WebKit/LayoutTests/intersection-observer/remove-element.html
@@ -1,16 +1,16 @@
<!DOCTYPE html>
<script src="../resources/js-test.js"></script>
<script src="helper-functions.js"></script>
-<div style="width:100%; height:700px;"></div>
<div id="root" style="display: inline-block; overflow-y: scroll; height: 200px; border: 3px solid black">
<div style="width:100px; height: 300px;"></div>
<div id="target" style="background-color: green; width:100px; height:100px"></div>
+ <div id="afterTarget" style="width:100px; height: 300px;"></div>
</div>
-<div style="width:100%;height:700px;"></div>
<script>
-description("Simple intersection observer test with explicit root and target in the same document.");
+description("Test that notifications are sent correctly when root and/or target are removed from the DOM tree.");
var target = document.getElementById("target");
+var afterTarget = document.getElementById("afterTarget");
var root = document.getElementById("root");
var entries = [];
var observer = new IntersectionObserver(
@@ -22,95 +22,80 @@ onload = function() {
observer.observe(target);
entries = entries.concat(observer.takeRecords());
shouldBeEqualToNumber("entries.length", 0);
- requestAnimationFrame(() => { requestAnimationFrame(step0) });
-}
-
-// Test that notifications are not generated when the target is overflow clipped by the root.
-function step0() {
- entries = entries.concat(observer.takeRecords());
- shouldBeEqualToNumber("entries.length", 0);
- document.scrollingElement.scrollTop = 600;
- requestAnimationFrame(step1);
-}
-
-function step1() {
- entries = entries.concat(observer.takeRecords());
- shouldBeEqualToNumber("entries.length", 0);
root.scrollTop = 150;
- requestAnimationFrame(step2);
+ requestAnimationFrame(() => { requestAnimationFrame(step1) });
}
-function step2() {
+function step1() {
entries = entries.concat(observer.takeRecords());
shouldBeEqualToNumber("entries.length", 1);
if (entries.length > 0) {
shouldBeEqualToNumber("entries[0].boundingClientRect.left", 11);
shouldBeEqualToNumber("entries[0].boundingClientRect.right", 111);
- shouldBeEqualToNumber("entries[0].boundingClientRect.top", 261);
- shouldBeEqualToNumber("entries[0].boundingClientRect.bottom", 361);
+ shouldBeEqualToNumber("entries[0].boundingClientRect.top", 161);
+ shouldBeEqualToNumber("entries[0].boundingClientRect.bottom", 261);
shouldBeEqualToNumber("entries[0].intersectionRect.left", 11);
shouldBeEqualToNumber("entries[0].intersectionRect.right", 111);
- shouldBeEqualToNumber("entries[0].intersectionRect.top", 261);
- shouldBeEqualToNumber("entries[0].intersectionRect.bottom", 311);
+ shouldBeEqualToNumber("entries[0].intersectionRect.top", 161);
+ shouldBeEqualToNumber("entries[0].intersectionRect.bottom", 211);
shouldBeEqualToNumber("entries[0].rootBounds.left", 11);
shouldBeEqualToNumber("entries[0].rootBounds.right", 111);
- shouldBeEqualToNumber("entries[0].rootBounds.top", 111);
- shouldBeEqualToNumber("entries[0].rootBounds.bottom", 311);
+ shouldBeEqualToNumber("entries[0].rootBounds.top", 11);
+ shouldBeEqualToNumber("entries[0].rootBounds.bottom", 211);
shouldEvaluateToSameObject("entries[0].target", target);
}
- document.scrollingElement.scrollTop = 0;
- requestAnimationFrame(step3);
-}
-
-function step3() {
- entries = entries.concat(observer.takeRecords());
- shouldBeEqualToNumber("entries.length", 1);
- root.scrollTop = 0;
- requestAnimationFrame(step4);
+ root.removeChild(target);
+ requestAnimationFrame(step2);
}
-function step4() {
+function step2() {
entries = entries.concat(observer.takeRecords());
shouldBeEqualToNumber("entries.length", 2);
if (entries.length > 1) {
- shouldBeEqualToNumber("entries[1].boundingClientRect.left", 11);
- shouldBeEqualToNumber("entries[1].boundingClientRect.right", 111);
- shouldBeEqualToNumber("entries[1].boundingClientRect.top", 1011);
- shouldBeEqualToNumber("entries[1].boundingClientRect.bottom", 1111);
+ shouldBeEqualToNumber("entries[1].boundingClientRect.left", 0);
+ shouldBeEqualToNumber("entries[1].boundingClientRect.right", 0);
+ shouldBeEqualToNumber("entries[1].boundingClientRect.top", 0);
+ shouldBeEqualToNumber("entries[1].boundingClientRect.bottom", 0)
shouldBeEqualToNumber("entries[1].intersectionRect.left", 0);
shouldBeEqualToNumber("entries[1].intersectionRect.right", 0);
shouldBeEqualToNumber("entries[1].intersectionRect.top", 0);
shouldBeEqualToNumber("entries[1].intersectionRect.bottom", 0);
- shouldBeEqualToNumber("entries[1].rootBounds.left", 11);
- shouldBeEqualToNumber("entries[1].rootBounds.right", 111);
- shouldBeEqualToNumber("entries[1].rootBounds.top", 711);
- shouldBeEqualToNumber("entries[1].rootBounds.bottom", 911);
+ shouldBeEqualToNumber("entries[1].rootBounds.left", 0);
+ shouldBeEqualToNumber("entries[1].rootBounds.right", 0);
+ shouldBeEqualToNumber("entries[1].rootBounds.top", 0);
+ shouldBeEqualToNumber("entries[1].rootBounds.bottom", 0);
shouldEvaluateToSameObject("entries[1].target", target);
}
+ root.scrollTop = 0;
+ root.insertBefore(target, afterTarget);
+ requestAnimationFrame(step3);
+}
+
+function step3() {
+ entries = entries.concat(observer.takeRecords());
+ shouldBeEqualToNumber("entries.length", 2);
root.scrollTop = 150;
- requestAnimationFrame(step5);
+ requestAnimationFrame(step4);
}
-// This tests that notifications are generated even when the root element is off screen.
-function step5() {
+function step4() {
entries = entries.concat(observer.takeRecords());
shouldBeEqualToNumber("entries.length", 3);
if (entries.length > 2) {
shouldBeEqualToNumber("entries[2].boundingClientRect.left", 11);
shouldBeEqualToNumber("entries[2].boundingClientRect.right", 111);
- shouldBeEqualToNumber("entries[2].boundingClientRect.top", 861);
- shouldBeEqualToNumber("entries[2].boundingClientRect.bottom", 961);
+ shouldBeEqualToNumber("entries[2].boundingClientRect.top", 161);
+ shouldBeEqualToNumber("entries[2].boundingClientRect.bottom", 261);
shouldBeEqualToNumber("entries[2].intersectionRect.left", 11);
shouldBeEqualToNumber("entries[2].intersectionRect.right", 111);
- shouldBeEqualToNumber("entries[2].intersectionRect.top", 861);
- shouldBeEqualToNumber("entries[2].intersectionRect.bottom", 911);
+ shouldBeEqualToNumber("entries[2].intersectionRect.top", 161);
+ shouldBeEqualToNumber("entries[2].intersectionRect.bottom", 211);
shouldBeEqualToNumber("entries[2].rootBounds.left", 11);
shouldBeEqualToNumber("entries[2].rootBounds.right", 111);
- shouldBeEqualToNumber("entries[2].rootBounds.top", 711);
- shouldBeEqualToNumber("entries[2].rootBounds.bottom", 911);
+ shouldBeEqualToNumber("entries[2].rootBounds.top", 11);
+ shouldBeEqualToNumber("entries[2].rootBounds.bottom", 211);
shouldEvaluateToSameObject("entries[2].target", target);
}
-
finishJSTest();
}
</script>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/intersection-observer/remove-element-expected.txt » ('j') | third_party/WebKit/Source/core/dom/IntersectionObservation.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698