|
|
Chromium Code Reviews|
Created:
4 years, 8 months ago by Dirk Pranke Modified:
4 years, 8 months ago CC:
chromium-reviews, brettw, Nico Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFlip Win x64 bots to GN.
R=brucedawson@chromium.org
BUG=581899
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
Committed: https://crrev.com/c588c9cb4be0ca87f2893bf7770d4d6e044ed05c
Cr-Commit-Position: refs/heads/master@{#388074}
Patch Set 1 #
Messages
Total messages: 32 (15 generated)
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888983002/1
Can you add more of the affected bots to the try job so that the builders verify more of the flavors? I could only see one flavor that was actually tested on the CQ dry run. But, lgtm.
Description was changed from ========== Flip Win x64 bots to GN. R=brucedawson@chromium.org BUG=581899 ========== to ========== Flip Win x64 bots to GN. R=brucedawson@chromium.org BUG=581899 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_rel_ng ==========
dpranke@chromium.org changed reviewers: + wfh@chromium.org
The CQ bit was unchecked by dpranke@chromium.org
Description was changed from ========== Flip Win x64 bots to GN. R=brucedawson@chromium.org BUG=581899 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_rel_ng ========== to ========== Flip Win x64 bots to GN. R=brucedawson@chromium.org BUG=581899 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_x64_chromium_rel_ng ==========
Description was changed from ========== Flip Win x64 bots to GN. R=brucedawson@chromium.org BUG=581899 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_x64_chromium_rel_ng ========== to ========== Flip Win x64 bots to GN. R=brucedawson@chromium.org BUG=581899 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng ==========
On 2016/04/15 00:30:46, brucedawson wrote: > Can you add more of the affected bots to the try job so that the builders verify > more of the flavors? I could only see one flavor that was actually tested on the > CQ dry run. There are only two trybots affected; one was running already, and I added the other (the win10 bot). I also added wfh@ to this since he's the one who added the win10 bot recently and probably cares. The other two affected bots are waterfall bots and we can't see what happens with them until the change lands :). It looks like we don't have a matching x64 debug compile bot, which is unfortunate. Once this lands (and sticks), I'll turn off the dedicated x64 GN bots, and we can repurpose them as (optional) trybots for the debug config.
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888983002/1
Hmm, Looks like crbug.com/586970 is going to block this. One of us should take a look at that bug tomorrow and see how hard it is going to be to fix.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by dpranke@chromium.org
trying again, now that the blacklist issue is hopefully fixed ...
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888983002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888983002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win10_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x6...)
On 2016/04/18 19:57:39, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > win10_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x6...) hmmmm views_unittests is flaky on windows 10 - crbug.com/604479 I think this CL looks okay...
The CQ bit was checked by dpranke@chromium.org
On 2016/04/18 20:31:45, Will Harris wrote: > On 2016/04/18 19:57:39, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > win10_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x6...) > > hmmmm > > views_unittests is flaky on windows 10 - crbug.com/604479 > > I think this CL looks okay... Let's try one more time and see what happens; if it flakes again, I'll drop CQ_INCLUDE_TRYBOTS from the description.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888983002/1
Message was sent while issue was closed.
Description was changed from ========== Flip Win x64 bots to GN. R=brucedawson@chromium.org BUG=581899 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng ========== to ========== Flip Win x64 bots to GN. R=brucedawson@chromium.org BUG=581899 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Flip Win x64 bots to GN. R=brucedawson@chromium.org BUG=581899 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng ========== to ========== Flip Win x64 bots to GN. R=brucedawson@chromium.org BUG=581899 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/c588c9cb4be0ca87f2893bf7770d4d6e044ed05c Cr-Commit-Position: refs/heads/master@{#388074} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c588c9cb4be0ca87f2893bf7770d4d6e044ed05c Cr-Commit-Position: refs/heads/master@{#388074} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
