ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm - Issue 1888963004: Add HttpProtocolHandler and convert everything to use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm

Issue 1888963004: Add HttpProtocolHandler and convert everything to use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-supports-scheme

Patch Set: rebase (needs fixing) Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm ('k') | ios/chrome/browser/ios_chrome_io_thread.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm

diff --git a/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm b/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm

index 4a886451306b191717d7ddf5ff569d12d79ce604..02676d2770b0dbc2054a0ac6ccc9a275f54b32ca 100644

--- a/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm

+++ b/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm

@@ -206,8 +206,8 @@ void OffTheRecordChromeBrowserStateIOData::InitializeInternal(

main_context->set_http_transaction_factory(main_http_factory_.get());

- std::unique_ptr<net::URLRequestJobFactoryImpl> main_job_factory(

- new net::URLRequestJobFactoryImpl());

+ std::unique_ptr<net::URLRequestJobFactoryImpl> main_job_factory =

+ net::URLRequestJobFactoryImpl::CreateWithHttpProtocolHandlers();

InstallProtocolHandlers(main_job_factory.get(), protocol_handlers);

URLRequestInterceptorScopedVector empty_interceptors;