Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc

Issue 1888963004: Add HttpProtocolHandler and convert everything to use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-supports-scheme
Patch Set: rebase (needs fixing) Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc
diff --git a/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc b/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc
index b903a386a0db2f3b9cc061f2a4e37dc1d8ad7a71..7476ba840a1001f3373a53085de474fb5518c2d9 100644
--- a/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc
+++ b/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc
@@ -21,6 +21,7 @@
#include "net/base/test_completion_callback.h"
#include "net/http/http_response_headers.h"
#include "net/url_request/url_request_context.h"
+#include "net/url_request/url_request_intercepting_job_factory.h"
#include "net/url_request/url_request_job_factory_impl.h"
#include "net/url_request/url_request_status.h"
#include "net/url_request/url_request_test_util.h"
@@ -64,7 +65,8 @@ class ServiceWorkerReadFromCacheJobTest : public testing::Test {
imported_script_(kImportedScriptResourceId,
GURL("http://example.com/imported.js"),
kResourceSize),
- test_job_interceptor_(nullptr) {}
+ test_job_interceptor_(nullptr),
+ test_job_factory_(nullptr) {}
~ServiceWorkerReadFromCacheJobTest() override {}
void SetUp() override {
@@ -75,9 +77,10 @@ class ServiceWorkerReadFromCacheJobTest : public testing::Test {
// The |test_job_factory_| takes ownership of the interceptor.
test_job_interceptor_ = new net::TestJobInterceptor();
- EXPECT_TRUE(test_job_factory_.SetProtocolHandler(
- url::kHttpScheme, base::WrapUnique(test_job_interceptor_)));
- url_request_context_->set_job_factory(&test_job_factory_);
+ test_job_factory_.reset(new net::URLRequestInterceptingJobFactory(
+ net::URLRequestJobFactoryImpl::CreateWithHttpProtocolHandlers(),
+ base::WrapUnique(test_job_interceptor_)));
+ url_request_context_->set_job_factory(test_job_factory_.get());
url_request_context_->Init();
}
@@ -182,7 +185,7 @@ class ServiceWorkerReadFromCacheJobTest : public testing::Test {
// |test_job_interceptor_| is owned by |test_job_factory_|.
net::TestJobInterceptor* test_job_interceptor_;
- net::URLRequestJobFactoryImpl test_job_factory_;
+ std::unique_ptr<net::URLRequestJobFactory> test_job_factory_;
std::unique_ptr<net::TestURLRequestContext> url_request_context_;
MockURLRequestDelegate delegate_;
« no previous file with comments | « content/browser/loader/resource_loader_unittest.cc ('k') | content/shell/browser/shell_url_request_context_getter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698