chrome/browser/io_thread.cc - Issue 1888963004: Add HttpProtocolHandler and convert everything to use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/io_thread.cc

Issue 1888963004: Add HttpProtocolHandler and convert everything to use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-supports-scheme

Patch Set: rebase (needs fixing) Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/net/aw_url_request_job_factory.cc ('k') | chrome/browser/profiles/off_the_record_profile_io_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/io_thread.cc

diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc

index c5c7ce179e4447693d969cfb3aae67c7f6c456b1..d344e8001b0e7976b008d0db6ff049ef46d96a44 100644

--- a/chrome/browser/io_thread.cc

+++ b/chrome/browser/io_thread.cc

@@ -869,8 +869,8 @@ net::URLRequestContext* IOThread::ConstructSystemRequestContext(

globals->http_auth_handler_factory.get());

context->set_proxy_service(globals->system_proxy_service.get());

- globals->system_url_request_job_factory.reset(

- new net::URLRequestJobFactoryImpl());

+ globals->system_url_request_job_factory =

+ net::URLRequestJobFactoryImpl::CreateWithHttpProtocolHandlers();

context->set_job_factory(globals->system_url_request_job_factory.get());

context->set_cookie_store(globals->system_cookie_store.get());

@@ -1050,8 +1050,8 @@ net::URLRequestContext* IOThread::ConstructProxyScriptFetcherContext(

context->set_http_transaction_factory(

globals->proxy_script_fetcher_http_transaction_factory.get());

- std::unique_ptr<net::URLRequestJobFactoryImpl> job_factory(

- new net::URLRequestJobFactoryImpl());

+ std::unique_ptr<net::URLRequestJobFactoryImpl> job_factory =

+ net::URLRequestJobFactoryImpl::CreateWithHttpProtocolHandlers();

job_factory->SetProtocolHandler(url::kDataScheme,

base::MakeUnique<net::DataProtocolHandler>());