ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm - Issue 1888963004: Add HttpProtocolHandler and convert everything to use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm

Issue 1888963004: Add HttpProtocolHandler and convert everything to use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-supports-scheme

Patch Set: more addressing comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc ('K') | « ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm ('k') | ios/chrome/browser/ios_chrome_io_thread.mm » ('j') | net/url_request/http_protocol_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm

diff --git a/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm b/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm

index 3a87bce2b7a68d5e05069d6914fa2d22a29c683a..b1ee538ad276f07f8d69ca2a7949eddfc6b1cbd3 100644

--- a/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm

+++ b/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm

@@ -208,8 +208,8 @@ void OffTheRecordChromeBrowserStateIOData::InitializeInternal(

main_context->set_http_transaction_factory(main_http_factory_.get());

- std::unique_ptr<net::URLRequestJobFactoryImpl> main_job_factory(

- new net::URLRequestJobFactoryImpl());

+ std::unique_ptr<net::URLRequestJobFactoryImpl> main_job_factory =

+ net::URLRequestJobFactoryImpl::CreateWithHttpProtocolHandlers();

InstallProtocolHandlers(main_job_factory.get(), protocol_handlers);

URLRequestInterceptorScopedVector empty_interceptors;