Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 1888963004: Add HttpProtocolHandler and convert everything to use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-supports-scheme
Patch Set: even more rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index 334f32859430d9de58a8475ff2aca67126f13f6d..18943f801a67790341f501cdf4c46be44aa820f8 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -96,6 +96,7 @@
#include "net/test/spawned_test_server/spawned_test_server.h"
#include "net/test/url_request/url_request_failed_job.h"
#include "net/url_request/data_protocol_handler.h"
+#include "net/url_request/http_protocol_handler.h"
#include "net/url_request/static_http_user_agent_settings.h"
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_filter.h"
@@ -715,8 +716,9 @@ class URLRequestTest : public PlatformTest {
URLRequestTest() : default_context_(true) {
default_context_.set_network_delegate(&default_network_delegate_);
default_context_.set_net_log(&net_log_);
- job_factory_impl_ = new URLRequestJobFactoryImpl();
- job_factory_.reset(job_factory_impl_);
+ job_factory_impl_ =
+ URLRequestJobFactoryImpl::CreateWithDefaultProtocolHandlers().release();
+ job_factory_ = base::WrapUnique(job_factory_impl_);
mmenke 2016/04/22 18:37:53 Anything we do here is a bit funky, but rather tha
mgersh 2016/04/22 20:27:15 Done.
}
~URLRequestTest() override {
@@ -734,6 +736,7 @@ class URLRequestTest : public PlatformTest {
virtual void SetUpFactory() {
job_factory_impl_->SetProtocolHandler(
"data", base::WrapUnique(new DataProtocolHandler));
+
#if !defined(DISABLE_FILE_SUPPORT)
job_factory_impl_->SetProtocolHandler(
"file", base::WrapUnique(new FileProtocolHandler(
« net/url_request/url_request_test_util.cc ('K') | « net/url_request/url_request_test_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698