net/url_request/url_request_job_factory_impl.h - Issue 1888963004: Add HttpProtocolHandler and convert everything to use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_job_factory_impl.h

Issue 1888963004: Add HttpProtocolHandler and convert everything to use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-supports-scheme

Patch Set: even more rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/url_request/http_protocol_handler.cc ('K') | « net/url_request/url_request_ftp_job_unittest.cc ('k') | net/url_request/url_request_job_factory_impl.cc » ('j') | net/url_request/url_request_job_factory_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_job_factory_impl.h

diff --git a/net/url_request/url_request_job_factory_impl.h b/net/url_request/url_request_job_factory_impl.h

index a0d0c490acb8485c9dff3dd35e3008f993f9ac79..c759aaa24f1835b555c40478c5f41e338a7a5ac6 100644

--- a/net/url_request/url_request_job_factory_impl.h

+++ b/net/url_request/url_request_job_factory_impl.h

@@ -23,6 +23,9 @@ class NET_EXPORT URLRequestJobFactoryImpl : public URLRequestJobFactory {

URLRequestJobFactoryImpl();

~URLRequestJobFactoryImpl() override;

+ static std::unique_ptr<URLRequestJobFactoryImpl>

+ CreateWithDefaultProtocolHandlers();

mmenke 2016/04/21 20:58:01 Think this needs a comment mentioning what schemes

mmenke 2016/04/21 20:58:01 Maybe rename with CreateWithHttpProtocolHandlers?

mgersh 2016/04/22 20:27:15 Done.

// Sets the ProtocolHandler for a scheme. Returns true on success, false on

// failure (a ProtocolHandler already exists for |scheme|).

bool SetProtocolHandler(const std::string& scheme,