Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Side by Side Diff: content/browser/loader/resource_loader_unittest.cc

Issue 1888963004: Add HttpProtocolHandler and convert everything to use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-supports-scheme
Patch Set: more addressing comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/loader/resource_loader.h" 5 #include "content/browser/loader/resource_loader.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 30 matching lines...) Expand all
41 #include "net/base/net_errors.h" 41 #include "net/base/net_errors.h"
42 #include "net/base/request_priority.h" 42 #include "net/base/request_priority.h"
43 #include "net/base/test_data_directory.h" 43 #include "net/base/test_data_directory.h"
44 #include "net/base/upload_bytes_element_reader.h" 44 #include "net/base/upload_bytes_element_reader.h"
45 #include "net/cert/x509_certificate.h" 45 #include "net/cert/x509_certificate.h"
46 #include "net/ssl/client_cert_store.h" 46 #include "net/ssl/client_cert_store.h"
47 #include "net/ssl/ssl_cert_request_info.h" 47 #include "net/ssl/ssl_cert_request_info.h"
48 #include "net/ssl/ssl_private_key.h" 48 #include "net/ssl/ssl_private_key.h"
49 #include "net/test/cert_test_util.h" 49 #include "net/test/cert_test_util.h"
50 #include "net/test/embedded_test_server/embedded_test_server.h" 50 #include "net/test/embedded_test_server/embedded_test_server.h"
51 #include "net/url_request/http_protocol_handler.h"
51 #include "net/url_request/url_request.h" 52 #include "net/url_request/url_request.h"
52 #include "net/url_request/url_request_filter.h" 53 #include "net/url_request/url_request_filter.h"
53 #include "net/url_request/url_request_interceptor.h" 54 #include "net/url_request/url_request_interceptor.h"
54 #include "net/url_request/url_request_job_factory.h" 55 #include "net/url_request/url_request_job_factory.h"
55 #include "net/url_request/url_request_job_factory_impl.h" 56 #include "net/url_request/url_request_job_factory_impl.h"
56 #include "net/url_request/url_request_test_job.h" 57 #include "net/url_request/url_request_test_job.h"
57 #include "net/url_request/url_request_test_util.h" 58 #include "net/url_request/url_request_test_util.h"
58 #include "storage/browser/blob/shareable_file_reference.h" 59 #include "storage/browser/blob/shareable_file_reference.h"
59 #include "testing/gtest/include/gtest/gtest.h" 60 #include "testing/gtest/include/gtest/gtest.h"
60 61
(...skipping 475 matching lines...) Expand 10 before | Expand all | Expand 10 after
536 base::Bind(callback, error, 537 base::Bind(callback, error,
537 base::Passed(std::unique_ptr<net::FileStream>()), nullptr)); 538 base::Passed(std::unique_ptr<net::FileStream>()), nullptr));
538 } 539 }
539 540
540 } // namespace 541 } // namespace
541 542
542 class ResourceLoaderTest : public testing::Test, 543 class ResourceLoaderTest : public testing::Test,
543 public ResourceLoaderDelegate { 544 public ResourceLoaderDelegate {
544 protected: 545 protected:
545 ResourceLoaderTest() 546 ResourceLoaderTest()
546 : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP), 547 : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP),
547 resource_context_(&test_url_request_context_), 548 job_factory_(
548 raw_ptr_resource_handler_(NULL), 549 net::URLRequestJobFactoryImpl::CreateWithHttpProtocolHandlers()),
549 raw_ptr_to_request_(NULL) { 550 resource_context_(&test_url_request_context_),
550 test_url_request_context_.set_job_factory(&job_factory_); 551 raw_ptr_resource_handler_(NULL),
552 raw_ptr_to_request_(NULL) {
553 test_url_request_context_.set_job_factory(job_factory_.get());
551 } 554 }
552 555
553 GURL test_url() const { return net::URLRequestTestJob::test_url_1(); } 556 GURL test_url() const { return net::URLRequestTestJob::test_url_1(); }
554 557
555 std::string test_data() const { 558 std::string test_data() const {
556 return net::URLRequestTestJob::test_data_1(); 559 return net::URLRequestTestJob::test_data_1();
557 } 560 }
558 561
559 virtual std::unique_ptr<net::URLRequestJobFactory::ProtocolHandler> 562 virtual std::unique_ptr<net::URLRequestJobFactory::ProtocolHandler>
560 CreateProtocolHandler() { 563 CreateProtocolHandler() {
(...skipping 20 matching lines...) Expand all
581 std::unique_ptr<ResourceHandlerStub> resource_handler( 584 std::unique_ptr<ResourceHandlerStub> resource_handler(
582 new ResourceHandlerStub(request.get())); 585 new ResourceHandlerStub(request.get()));
583 raw_ptr_resource_handler_ = resource_handler.get(); 586 raw_ptr_resource_handler_ = resource_handler.get();
584 loader_.reset(new ResourceLoader( 587 loader_.reset(new ResourceLoader(
585 std::move(request), 588 std::move(request),
586 WrapResourceHandler(std::move(resource_handler), raw_ptr_to_request_), 589 WrapResourceHandler(std::move(resource_handler), raw_ptr_to_request_),
587 CertStore::GetInstance(), this)); 590 CertStore::GetInstance(), this));
588 } 591 }
589 592
590 void SetUp() override { 593 void SetUp() override {
591 job_factory_.SetProtocolHandler("test", CreateProtocolHandler()); 594 job_factory_->SetProtocolHandler("test", CreateProtocolHandler());
592 595
593 browser_context_.reset(new TestBrowserContext()); 596 browser_context_.reset(new TestBrowserContext());
594 scoped_refptr<SiteInstance> site_instance = 597 scoped_refptr<SiteInstance> site_instance =
595 SiteInstance::Create(browser_context_.get()); 598 SiteInstance::Create(browser_context_.get());
596 web_contents_.reset( 599 web_contents_.reset(
597 TestWebContents::Create(browser_context_.get(), site_instance.get())); 600 TestWebContents::Create(browser_context_.get(), site_instance.get()));
598 601
599 std::unique_ptr<net::URLRequest> request( 602 std::unique_ptr<net::URLRequest> request(
600 resource_context_.GetRequestContext()->CreateRequest( 603 resource_context_.GetRequestContext()->CreateRequest(
601 test_url(), net::DEFAULT_PRIORITY, nullptr /* delegate */)); 604 test_url(), net::DEFAULT_PRIORITY, nullptr /* delegate */));
(...skipping 20 matching lines...) Expand all
622 } 625 }
623 void DidStartRequest(ResourceLoader* loader) override {} 626 void DidStartRequest(ResourceLoader* loader) override {}
624 void DidReceiveRedirect(ResourceLoader* loader, 627 void DidReceiveRedirect(ResourceLoader* loader,
625 const GURL& new_url) override {} 628 const GURL& new_url) override {}
626 void DidReceiveResponse(ResourceLoader* loader) override {} 629 void DidReceiveResponse(ResourceLoader* loader) override {}
627 void DidFinishLoading(ResourceLoader* loader) override {} 630 void DidFinishLoading(ResourceLoader* loader) override {}
628 631
629 TestBrowserThreadBundle thread_bundle_; 632 TestBrowserThreadBundle thread_bundle_;
630 RenderViewHostTestEnabler rvh_test_enabler_; 633 RenderViewHostTestEnabler rvh_test_enabler_;
631 634
632 net::URLRequestJobFactoryImpl job_factory_; 635 std::unique_ptr<net::URLRequestJobFactoryImpl> job_factory_;
633 net::TestURLRequestContext test_url_request_context_; 636 net::TestURLRequestContext test_url_request_context_;
634 ResourceContextStub resource_context_; 637 ResourceContextStub resource_context_;
635 std::unique_ptr<TestBrowserContext> browser_context_; 638 std::unique_ptr<TestBrowserContext> browser_context_;
636 std::unique_ptr<TestWebContents> web_contents_; 639 std::unique_ptr<TestWebContents> web_contents_;
637 640
638 // The ResourceLoader owns the URLRequest and the ResourceHandler. 641 // The ResourceLoader owns the URLRequest and the ResourceHandler.
639 ResourceHandlerStub* raw_ptr_resource_handler_; 642 ResourceHandlerStub* raw_ptr_resource_handler_;
640 net::URLRequest* raw_ptr_to_request_; 643 net::URLRequest* raw_ptr_to_request_;
641 std::unique_ptr<ResourceLoader> loader_; 644 std::unique_ptr<ResourceLoader> loader_;
642 }; 645 };
(...skipping 503 matching lines...) Expand 10 before | Expand all | Expand 10 after
1146 ASSERT_TRUE( 1149 ASSERT_TRUE(
1147 CertStore::GetInstance()->RetrieveCert(deserialized.cert_id, &cert)); 1150 CertStore::GetInstance()->RetrieveCert(deserialized.cert_id, &cert));
1148 EXPECT_TRUE(cert->Equals(GetTestCert().get())); 1151 EXPECT_TRUE(cert->Equals(GetTestCert().get()));
1149 1152
1150 EXPECT_EQ(kTestCertError, deserialized.cert_status); 1153 EXPECT_EQ(kTestCertError, deserialized.cert_status);
1151 EXPECT_EQ(kTestConnectionStatus, deserialized.connection_status); 1154 EXPECT_EQ(kTestConnectionStatus, deserialized.connection_status);
1152 EXPECT_EQ(kTestSecurityBits, deserialized.security_bits); 1155 EXPECT_EQ(kTestSecurityBits, deserialized.security_bits);
1153 } 1156 }
1154 1157
1155 } // namespace content 1158 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698