Add HttpProtocolHandler and convert everything to use it

components/cronet/ios/cronet_environment.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/cronet/ios/cronet_environment.h"
 
 #include <utility>
 
 #include "base/at_exit.h"
 #include "base/atomicops.h"
@@ skipping 334 matching lines @@
 
   // TODO(mmenke):  These really shouldn't be leaked.
   //                See https://crbug.com/523858.
   net::HttpNetworkSession* http_network_session =
       new net::HttpNetworkSession(params);
   net::HttpCache* main_cache =
       new net::HttpCache(http_network_session, std::move(main_backend),
                          true /* set_up_quic_server_info */);
   main_context_->set_http_transaction_factory(main_cache);
 
-  net::URLRequestJobFactoryImpl* job_factory =
-      new net::URLRequestJobFactoryImpl;
-  main_context_->set_job_factory(job_factory);
+  std::unique_ptr<net::URLRequestJobFactoryImpl> job_factory =
+      net::URLRequestJobFactoryImpl::CreateWithDefaultProtocolHandlers();

[mmenke, 2016/04/22 18:37:52]

Could you add a TODO about fixing this leak?

[mgersh, 2016/04/22 20:27:15]

This function, and the crnet equivalent, already have two TODOs about this,
including one about five lines up from here, which link to a bug that applies to
the entire thing. Do you think it needs another one specifically here?

[mmenke, 2016/04/22 20:41:04]

I'd say yes, just to make it clearer that this is yet another instance of a
leak.  Or could update the comments about fixing leaks to make it clearer that
this is also being leaked.

[mgersh, 2016/04/27 16:13:52]

Done.

+  main_context_->set_job_factory(job_factory.release());
   main_context_->set_net_log(net_log_.get());
 }
 
 std::string CronetEnvironment::user_agent() {
   const net::HttpUserAgentSettings* user_agent_settings =
       main_context_->http_user_agent_settings();
   if (!user_agent_settings) {
     return nullptr;
   }
 
   return user_agent_settings->GetUserAgent();
 }
 
 }  // namespace cronet