content/browser/frame_host/navigator_impl.cc - Issue 1888913003: PlzNavigate: fix test FrameNavigationEntry_SubframeHistoryFallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 1888913003: PlzNavigate: fix test FrameNavigationEntry_SubframeHistoryFallback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + addressed comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index b7da1a0ccbaf13f1f822f30fcfd51da068d5f641..0cf5f6e169da186736ebbb75763bd51fd4ce76f9 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -675,7 +675,7 @@ void NavigatorImpl::RequestOpenURL(RenderFrameHostImpl* render_frame_host,

// Send the navigation to the current FrameTreeNode if it's destined for a

// subframe in the current tab. We'll assume it's for the main frame

// (possibly of a new or different WebContents) otherwise.

- if (SiteIsolationPolicy::AreCrossProcessFramesPossible() &&

+ if (SiteIsolationPolicy::UseSubframeNavigationEntries() &&

disposition == CURRENT_TAB && render_frame_host->GetParent()) {

frame_tree_node_id =

render_frame_host->frame_tree_node()->frame_tree_node_id();

« no previous file with comments | « no previous file | testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter » ('j') | no next file with comments »