Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1888893002: Make CPDF_ApSettings take CFX_ByteString args. (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make CPDF_ApSettings take CFX_ByteString args. These are immediately used to access a dictionary, so the use of static CFX_ByteStringCs may force duplicate allocations. BUG= Committed: https://pdfium.googlesource.com/pdfium/+/3bac505132235c009b4b79aa4ac238afad5366e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -59 lines) Patch
M core/fpdfdoc/doc_formcontrol.cpp View 6 chunks +20 lines, -18 lines 0 comments Download
M core/fpdfdoc/include/fpdf_doc.h View 5 chunks +13 lines, -41 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Dan, for review.
4 years, 8 months ago (2016-04-14 18:39:09 UTC) #2
dsinclair
lgtm
4 years, 8 months ago (2016-04-14 19:02:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888893002/1
4 years, 8 months ago (2016-04-14 19:02:17 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 19:13:36 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/3bac505132235c009b4b79aa4ac238afad53...

Powered by Google App Engine
This is Rietveld 408576698