Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1888883004: clang update.py: Make DIA backwards compatible (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
chromium-reviews, dmikurube+clang_chromium.org, eugenis+clang_chromium.org, glider+clang_chromium.org, ukai+watch_chromium.org, yunlian
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang update.py: Make DIA backwards compatible Fix after https://codereview.chromium.org/1879753002/ to continue supporting MSVS 2013. BUG=603011 Committed: https://crrev.com/f569b921bb3228ccd0dfb632bfdeb28b7f6b3704 Cr-Commit-Position: refs/heads/master@{#387580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M tools/clang/scripts/update.py View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888883004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888883004/1
4 years, 8 months ago (2016-04-15 08:16:27 UTC) #4
Michael Achenbach
PTAL
4 years, 8 months ago (2016-04-15 08:17:26 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 09:19:23 UTC) #7
Nico
lgtm
4 years, 8 months ago (2016-04-15 11:38:56 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-15 11:43:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888883004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888883004/1
4 years, 8 months ago (2016-04-15 12:05:39 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 12:14:26 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 12:16:15 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f569b921bb3228ccd0dfb632bfdeb28b7f6b3704
Cr-Commit-Position: refs/heads/master@{#387580}

Powered by Google App Engine
This is Rietveld 408576698