Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1888843004: Still more comments about strings (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : One more line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M core/fxcrt/include/fx_string.h View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Tom Sepez
Lei, even more accurate comments.
4 years, 8 months ago (2016-04-15 00:09:38 UTC) #1
Tom Sepez
https://codereview.chromium.org/1888843004/diff/1/core/fxcrt/include/fx_string.h File core/fxcrt/include/fx_string.h (right): https://codereview.chromium.org/1888843004/diff/1/core/fxcrt/include/fx_string.h#newcode367 core/fxcrt/include/fx_string.h:367: // |ch| must be an lvalue that outlives the ...
4 years, 8 months ago (2016-04-15 00:09:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888843004/1
4 years, 8 months ago (2016-04-15 00:10:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888843004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888843004/20001
4 years, 8 months ago (2016-04-15 00:20:37 UTC) #7
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-15 00:37:40 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 00:39:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/80b103bf53ee1249823e6bb3bed9cb2bc15c...

Powered by Google App Engine
This is Rietveld 408576698