[Mac/GN] Initial mac_app_bundle template.

[Mac/GN] Initial mac_app_bundle template.

This also creates a dummy content_shell_helper_app target that will need further
refinement after the content_shell_framework is built.

R=sdefresne@chromium.org
BUG=297668
Committed: https://crrev.com/20a58a6f5876bebf356d212221835f3aac284c79
Cr-Commit-Position: refs/heads/master@{#387693}

[Robert Sesek, 2016-04-15 15:32:38]

rsesek@chromium.org changed reviewers:
+ dpranke@chromium.org

[Robert Sesek, 2016-04-15 15:32:38]

+dpranke since sdefresne is ooo today

[Dirk Pranke, 2016-04-15 18:19:25]

lgtm

https://codereview.chromium.org/1888833002/diff/20001/build/config/mac/rules.gni
File build/config/mac/rules.gni (right):

https://codereview.chromium.org/1888833002/diff/20001/build/config/mac/rules....
build/config/mac/rules.gni:185: #         .framework suffix. If omitted,
defaults to target_name.
This should be .app, not .framework, right?

[Robert Sesek, 2016-04-15 19:08:42]

https://codereview.chromium.org/1888833002/diff/20001/build/config/mac/rules.gni
File build/config/mac/rules.gni (right):

https://codereview.chromium.org/1888833002/diff/20001/build/config/mac/rules....
build/config/mac/rules.gni:185: #         .framework suffix. If omitted,
defaults to target_name.
On 2016/04/15 18:19:24, Dirk Pranke wrote:
> This should be .app, not .framework, right?

Done.

[Robert Sesek, 2016-04-15 19:08:56]

+avi for //content OWNERS. Please cq if lg.

[Robert Sesek, 2016-04-15 19:10:48]

rsesek@chromium.org changed reviewers:
+ jam@chromium.org

[Robert Sesek, 2016-04-15 19:10:49]

+jam for //content OWNERS

[Robert Sesek, 2016-04-15 19:15:28]

The CQ bit was checked by rsesek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-15 19:15:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1888833002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1888833002/40001

[commit-bot: I haz the power, 2016-04-15 19:50:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 19:50:41]

Dry run: This issue passed the CQ dry run.

[jam, 2016-04-15 20:54:20]

lgtm

[jam, 2016-04-15 20:54:24]

The CQ bit was checked by jam@chromium.org

[jam, 2016-04-15 20:54:25]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1888833002/#ps40001
(title: "Fix comment")

[commit-bot: I haz the power, 2016-04-15 20:54:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1888833002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1888833002/40001

[commit-bot: I haz the power, 2016-04-15 20:59:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-15 21:00:33]

Description was changed from

==========
[Mac/GN] Initial mac_app_bundle template.

This also creates a dummy content_shell_helper_app target that will need further
refinement after the content_shell_framework is built.

R=sdefresne@chromium.org
BUG=297668
==========

to

==========
[Mac/GN] Initial mac_app_bundle template.

This also creates a dummy content_shell_helper_app target that will need further
refinement after the content_shell_framework is built.

R=sdefresne@chromium.org
BUG=297668

Committed: https://crrev.com/20a58a6f5876bebf356d212221835f3aac284c79
Cr-Commit-Position: refs/heads/master@{#387693}
==========

[commit-bot: I haz the power, 2016-04-15 21:00:34]

Patchset 3 (id:??) landed as
https://crrev.com/20a58a6f5876bebf356d212221835f3aac284c79
Cr-Commit-Position: refs/heads/master@{#387693}