Replace CR/NL by space - don't remove altogether when xml:space=default

Replace CR/NL by space - don't remove altogether when xml:space=default

This moves handling of xml:space=default closer to the more generic
white-space handling, by not removing CR and NL characters, but rather
just replacing them with a regular space.
This modifies behavior, but means aligning with non-WebKit browser
engines.
This also simplifies the code a bit - with promise of further
simplification (or rather assimilation.)

TEST=svg/custom/text-whitespace-handling.svg
BUG=602606, 366558
Committed: https://crrev.com/0c39a6f29e59594a7b9c412a8203af9fc43e4ecd
Cr-Commit-Position: refs/heads/master@{#387440}

[fs, 2016-04-14 15:22:45]

Description was changed from

==========
Replace newlines by spaces - don't remove them altogether

BUG=602606
==========

to

==========
Replace newlines by spaces - don't remove them altogether

BUG=602606, 366558
==========

[fs, 2016-04-14 16:17:20]

Description was changed from

==========
Replace newlines by spaces - don't remove them altogether

BUG=602606, 366558
==========

to

==========
Replace CR/NL by space - don't remove altogether when xml:space=default

This moves handling of xml:space=default closer to the more generic
white-space handling, by not removing CR and NL characters, but rather
just replacing them with a regular space.
This modifies behavior, but means aligning with non-WebKit browser
engines.
This also simplifies the code a bit - with promise of further
simplification (or rather assimilation.)

BUG=602606, 366558
==========

[fs, 2016-04-14 16:18:22]

Description was changed from

==========
Replace CR/NL by space - don't remove altogether when xml:space=default

This moves handling of xml:space=default closer to the more generic
white-space handling, by not removing CR and NL characters, but rather
just replacing them with a regular space.
This modifies behavior, but means aligning with non-WebKit browser
engines.
This also simplifies the code a bit - with promise of further
simplification (or rather assimilation.)

BUG=602606, 366558
==========

to

==========
Replace CR/NL by space - don't remove altogether when xml:space=default

This moves handling of xml:space=default closer to the more generic
white-space handling, by not removing CR and NL characters, but rather
just replacing them with a regular space.
This modifies behavior, but means aligning with non-WebKit browser
engines.
This also simplifies the code a bit - with promise of further
simplification (or rather assimilation.)

TEST=svg/custom/text-whitespace-handling.svg
BUG=602606, 366558
==========

[fs, 2016-04-14 17:40:21]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[fs, 2016-04-14 17:40:21]

Test-changes break-down:

" \n" -> "  " transition leading to (one) additional line box:

  svg/W3C-SVG-1.1/styling-css-02-b.svg
  svg/W3C-SVG-1.1/text-ws-01-t.svg
  svg/text/text-selection-ws-01-t.svg


Text nodes with only "\n" - now no longer "empty", so showing up as empty (zero
dim.):

  svg/W3C-SVG-1.1/text-align-08-b.svg
  svg/custom/invalid-text-content.svg
  svg/text/textPathBoundsBug.svg


"\n" are preserved, leading to "longer" text nodes and affecting offsets in
selection:

  svg/W3C-SVG-1.1/text-tselect-02-f.svg
  svg/text/text-selection-tselect-02-f.svg


The poster child for this change; showing the change in behavior (the only
visual change):

  svg/custom/text-whitespace-handling.svg

[pdr., 2016-04-14 21:24:16]

On 2016/04/14 at 17:40:21, fs wrote:
> Test-changes break-down:
> 
> " \n" -> "  " transition leading to (one) additional line box:
> 
>   svg/W3C-SVG-1.1/styling-css-02-b.svg
>   svg/W3C-SVG-1.1/text-ws-01-t.svg
>   svg/text/text-selection-ws-01-t.svg
> 
> 
> Text nodes with only "\n" - now no longer "empty", so showing up as empty
(zero dim.):
> 
>   svg/W3C-SVG-1.1/text-align-08-b.svg
>   svg/custom/invalid-text-content.svg
>   svg/text/textPathBoundsBug.svg
> 
> 
> "\n" are preserved, leading to "longer" text nodes and affecting offsets in
selection:
> 
>   svg/W3C-SVG-1.1/text-tselect-02-f.svg
>   svg/text/text-selection-tselect-02-f.svg
> 
> 
> The poster child for this change; showing the change in behavior (the only
visual change):
> 
>   svg/custom/text-whitespace-handling.svg

LGTM

[fs, 2016-04-14 21:51:27]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-04-14 21:51:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1888823002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1888823002/20001

[commit-bot: I haz the power, 2016-04-14 21:58:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-14 21:59:40]

Description was changed from

==========
Replace CR/NL by space - don't remove altogether when xml:space=default

This moves handling of xml:space=default closer to the more generic
white-space handling, by not removing CR and NL characters, but rather
just replacing them with a regular space.
This modifies behavior, but means aligning with non-WebKit browser
engines.
This also simplifies the code a bit - with promise of further
simplification (or rather assimilation.)

TEST=svg/custom/text-whitespace-handling.svg
BUG=602606, 366558
==========

to

==========
Replace CR/NL by space - don't remove altogether when xml:space=default

This moves handling of xml:space=default closer to the more generic
white-space handling, by not removing CR and NL characters, but rather
just replacing them with a regular space.
This modifies behavior, but means aligning with non-WebKit browser
engines.
This also simplifies the code a bit - with promise of further
simplification (or rather assimilation.)

TEST=svg/custom/text-whitespace-handling.svg
BUG=602606, 366558

Committed: https://crrev.com/0c39a6f29e59594a7b9c412a8203af9fc43e4ecd
Cr-Commit-Position: refs/heads/master@{#387440}
==========

[commit-bot: I haz the power, 2016-04-14 21:59:42]

Patchset 2 (id:??) landed as
https://crrev.com/0c39a6f29e59594a7b9c412a8203af9fc43e4ecd
Cr-Commit-Position: refs/heads/master@{#387440}