Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1888803002: Support serialization of all resolved asts from dart:core (Closed)

Created:
4 years, 8 months ago by Johnni Winther
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support serialization of all resolved asts from dart:core R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/14baf6b37ba7fd4cb9c1d08f4039e1153b1fdc27

Patch Set 1 #

Patch Set 2 : Cleanup. #

Total comments: 4

Patch Set 3 : Updated cf. comments. #

Patch Set 4 : Fix unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -48 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 5 chunks +13 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 2 3 3 chunks +34 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser.dart View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/serialization/constant_serialization.dart View 1 2 chunks +7 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/serialization_resolved_ast_test.dart View 1 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 8 months ago (2016-04-14 14:13:02 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1888803002/diff/20001/pkg/compiler/lib/src/js_backend/backend_helpers.dart File pkg/compiler/lib/src/js_backend/backend_helpers.dart (right): https://codereview.chromium.org/1888803002/diff/20001/pkg/compiler/lib/src/js_backend/backend_helpers.dart#newcode181 pkg/compiler/lib/src/js_backend/backend_helpers.dart:181: ClassElement get symbolImplementationClass { nit - rewrite as: ...
4 years, 8 months ago (2016-04-14 15:38:20 UTC) #3
Johnni Winther
https://codereview.chromium.org/1888803002/diff/20001/pkg/compiler/lib/src/js_backend/backend_helpers.dart File pkg/compiler/lib/src/js_backend/backend_helpers.dart (right): https://codereview.chromium.org/1888803002/diff/20001/pkg/compiler/lib/src/js_backend/backend_helpers.dart#newcode181 pkg/compiler/lib/src/js_backend/backend_helpers.dart:181: ClassElement get symbolImplementationClass { On 2016/04/14 15:38:20, Siggi Cherem ...
4 years, 8 months ago (2016-04-15 07:27:43 UTC) #4
Johnni Winther
4 years, 8 months ago (2016-04-15 08:34:28 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
14baf6b37ba7fd4cb9c1d08f4039e1153b1fdc27 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698