Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 1888783002: VM: Always start switchable calls with IC stub. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_x64.cc
diff --git a/runtime/vm/flow_graph_compiler_x64.cc b/runtime/vm/flow_graph_compiler_x64.cc
index e044923a6cbfce33366e5aad8c97bcfe8df471e3..bdcc3b4d1119eb5d514176cecf5dde82df83903b 100644
--- a/runtime/vm/flow_graph_compiler_x64.cc
+++ b/runtime/vm/flow_graph_compiler_x64.cc
@@ -1375,21 +1375,9 @@ void FlowGraphCompiler::EmitSwitchableInstanceCall(
LocationSummary* locs) {
__ Comment("SwitchableCall");
__ movq(RDI, Address(RSP, (argument_count - 1) * kWordSize));
- if (ic_data.NumArgsTested() == 1) {
- __ LoadUniqueObject(RBX, ic_data);
- __ CallPatchable(*StubCode::ICLookupThroughFunction_entry());
- } else {
- const String& name = String::Handle(zone(), ic_data.target_name());
- const Array& arguments_descriptor =
- Array::ZoneHandle(zone(), ic_data.arguments_descriptor());
- ASSERT(!arguments_descriptor.IsNull() &&
- (arguments_descriptor.Length() > 0));
- const MegamorphicCache& cache = MegamorphicCache::ZoneHandle(zone(),
- MegamorphicCacheTable::Lookup(isolate(), name, arguments_descriptor));
-
- __ LoadUniqueObject(RBX, cache);
- __ CallPatchable(*StubCode::MegamorphicLookup_entry());
- }
+ ASSERT(ic_data.NumArgsTested() == 1);
+ __ LoadUniqueObject(RBX, ic_data);
+ __ CallPatchable(*StubCode::ICLookupThroughFunction_entry());
__ call(RCX);
AddCurrentDescriptor(RawPcDescriptors::kOther,
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698