|
Merge DragClientImpl into core.
This adds ChromeClient methods so core can call the WebViewClient methods for
dragging removing the need for DragClient. It also merges all the code from
DragClient down into core so the drag logic lives in one places. To do this I
also had to move the WebDragOperation.h header into platform so both web/ and
core/ could depend on it.
This also exposed some dead code in web/, like tracking the last mouse position
for dragging, but nothing actually used that value.
BUG= 603795
Committed: https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198
Cr-Commit-Position: refs/heads/master@{#387639}
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+97 lines, -347 lines) |
Patch |
 |
M |
components/test_runner/event_sender.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/test_runner/web_test_proxy.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/DEPS
|
View
|
|
3 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/browser/browser_plugin/browser_plugin_embedder.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/browser_plugin/browser_plugin_guest.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_view_host_delegate_view.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_view_host_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/web_contents/web_contents_impl.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/web_contents/web_contents_view_mus.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/web_contents/web_drag_utils_win.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/common/DEPS
|
View
|
|
4 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
content/common/browser_plugin/browser_plugin_messages.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/common/drag_messages.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/common/drag_traits.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/public/browser/render_view_host.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/public/browser/web_contents_delegate.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/loader/EmptyClients.h
|
View
|
|
3 chunks |
+3 lines, -10 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/loader/EmptyClients.cpp
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/page/ChromeClient.h
|
View
|
|
3 chunks |
+11 lines, -3 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/Source/core/page/DragClient.h
|
View
|
|
1 chunk |
+0 lines, -50 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/page/DragController.h
|
View
|
|
4 chunks |
+2 lines, -5 lines |
1 comment
|
Download
|
 |
M |
third_party/WebKit/Source/core/page/DragController.cpp
|
View
|
|
7 chunks |
+38 lines, -22 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/page/Page.h
|
View
|
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/page/Page.cpp
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/testing/DummyPageHolder.cpp
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/ChromeClientImpl.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/ChromeClientImpl.cpp
|
View
|
|
1 chunk |
+14 lines, -0 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/Source/web/DragClientImpl.h
|
View
|
|
1 chunk |
+0 lines, -60 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/Source/web/DragClientImpl.cpp
|
View
|
|
1 chunk |
+0 lines, -82 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/WebViewImpl.h
|
View
|
|
4 chunks |
+0 lines, -16 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/WebViewImpl.cpp
|
View
|
|
3 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/tests/WebViewTest.cpp
|
View
|
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/web.gypi
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/public/blink_headers.gypi
|
View
|
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
 |
A + |
third_party/WebKit/public/platform/WebDragOperation.h
|
View
|
1
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/public/web/WebDragOperation.h
|
View
|
|
1 chunk |
+0 lines, -59 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/public/web/WebPlugin.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/public/web/WebView.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/public/web/WebViewClient.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 22 (10 generated)
|