Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1888773003: Merge DragClientImpl into core. (Closed)

Created:
4 years, 8 months ago by esprehn
Modified:
4 years, 8 months ago
Reviewers:
jam, dcheng
CC:
dcheng, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jam, Nate Chapin, jochen+watch_chromium.org, loading-reviews_chromium.org, mlamouri+watch-test-runner_chromium.org, nasko+codewatch_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge DragClientImpl into core. This adds ChromeClient methods so core can call the WebViewClient methods for dragging removing the need for DragClient. It also merges all the code from DragClient down into core so the drag logic lives in one places. To do this I also had to move the WebDragOperation.h header into platform so both web/ and core/ could depend on it. This also exposed some dead code in web/, like tracking the last mouse position for dragging, but nothing actually used that value. BUG=603795 Committed: https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198 Cr-Commit-Position: refs/heads/master@{#387639}

Patch Set 1 #

Patch Set 2 : missing file. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -347 lines) Patch
M components/test_runner/event_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/web_test_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/DEPS View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_embedder.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate_view.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_drag_utils_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/DEPS View 4 chunks +6 lines, -6 lines 0 comments Download
M content/common/browser_plugin/browser_plugin_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/drag_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/drag_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 3 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 3 chunks +11 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/page/DragClient.h View 1 chunk +0 lines, -50 lines 0 comments Download
M third_party/WebKit/Source/core/page/DragController.h View 4 chunks +2 lines, -5 lines 1 comment Download
M third_party/WebKit/Source/core/page/DragController.cpp View 7 chunks +38 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DummyPageHolder.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/web/DragClientImpl.h View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/Source/web/DragClientImpl.cpp View 1 chunk +0 lines, -82 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 4 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 2 chunks +1 line, -1 line 0 comments Download
A + third_party/WebKit/public/platform/WebDragOperation.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/public/web/WebDragOperation.h View 1 chunk +0 lines, -59 lines 0 comments Download
M third_party/WebKit/public/web/WebPlugin.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebView.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebViewClient.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888773003/1
4 years, 8 months ago (2016-04-15 01:24:22 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/95889)
4 years, 8 months ago (2016-04-15 01:34:15 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888773003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888773003/20001
4 years, 8 months ago (2016-04-15 01:38:25 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 03:28:31 UTC) #8
esprehn
4 years, 8 months ago (2016-04-15 03:29:54 UTC) #12
esprehn
4 years, 8 months ago (2016-04-15 05:49:50 UTC) #14
dcheng
third_party/WebKit LGTM https://codereview.chromium.org/1888773003/diff/20001/third_party/WebKit/Source/core/page/DragController.h File third_party/WebKit/Source/core/page/DragController.h (right): https://codereview.chromium.org/1888773003/diff/20001/third_party/WebKit/Source/core/page/DragController.h#newcode80 third_party/WebKit/Source/core/page/DragController.h:80: DragController(Page*); Nit: explicit
4 years, 8 months ago (2016-04-15 07:20:35 UTC) #15
jam
lgtm
4 years, 8 months ago (2016-04-15 15:26:35 UTC) #16
dglazkov
glorious.
4 years, 8 months ago (2016-04-15 15:47:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888773003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888773003/20001
4 years, 8 months ago (2016-04-15 17:49:01 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 18:00:09 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 18:01:23 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198
Cr-Commit-Position: refs/heads/master@{#387639}

Powered by Google App Engine
This is Rietveld 408576698