third_party/libwebp/BUILD.gn - Issue 1888763002: Build 64bit browser for Android with clang for ARMv8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libwebp/BUILD.gn

Issue 1888763002: Build 64bit browser for Android with clang for ARMv8 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch Set 2 - Build 64bit browser for Android with clang for ARMv8 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/libwebp/BUILD.gn

diff --git a/third_party/libwebp/BUILD.gn b/third_party/libwebp/BUILD.gn

index 676a5d1d7bd3fe8f40c8905d663a7055ed8b63ec..859b136c5978bec9136c98574e8fabde1f5aa029 100644

--- a/third_party/libwebp/BUILD.gn

+++ b/third_party/libwebp/BUILD.gn

@@ -195,7 +195,7 @@ if (use_dsp_neon) {

# behavior similar to *.c.neon in an Android.mk

configs -= [ "//build/config/compiler:compiler_arm_fpu" ]

cflags = [ "-mfpu=neon" ]

- } else if (current_cpu == "arm64") {

+ } else if (current_cpu == "arm64" && !is_clang) {

# avoid an ICE with gcc-4.9: b/15574841

cflags = [ "-frename-registers" ]

}

« build/config/compiler/BUILD.gn ('K') | « third_party/boringssl/BUILD.gn ('k') | no next file » | no next file with comments »