third_party/boringssl/BUILD.gn - Issue 1888763002: Build 64bit browser for Android with clang for ARMv8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/boringssl/BUILD.gn

Issue 1888763002: Build 64bit browser for Android with clang for ARMv8 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/audio/DenormalDisabler.h ('K') | « third_party/WebKit/Source/platform/audio/DenormalDisabler.h ('k') | third_party/libwebp/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/boringssl/BUILD.gn

diff --git a/third_party/boringssl/BUILD.gn b/third_party/boringssl/BUILD.gn

index 9b9badaa78099f08779fc50bee12906e33e37062..7018dcfe4b42dccef2efb6883f1ed77d80d63f49 100644

--- a/third_party/boringssl/BUILD.gn

+++ b/third_party/boringssl/BUILD.gn

@@ -67,7 +67,7 @@ if (is_win && !is_msan) {

asmflags = []

include_dirs = [ "src/include" ]

- if (current_cpu == "arm" && is_clang) {

+ if ((current_cpu == "arm" || current_cpu == "arm64") && is_clang) {

# TODO(hans) Enable integrated-as (crbug.com/124610).

asmflags += [ "-fno-integrated-as" ]

if (is_android) {

@@ -104,7 +104,7 @@ if (is_win && !is_msan) {

# TODO(davidben): Remove explicit arch flag once https://crbug.com/576858

# is fixed.

- asmflags += [ "-march=armv8-a+crypto" ]

+ asmflags += [ "-march=armv8-a+crypto+simd+fp+crc" ]

Nico 2016/04/14 15:43:55 can we fix https://llvm.org/bugs/show_bug.cgi?id=2

khasim.mohammed 2016/04/14 16:38:46 Not sure if I can get that fixed quickly. Will try

} else {

public_configs = [ ":no_asm_config" ]

}