Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1888733002: Revert of Only create DockedBackgroundWidget as needed. (Closed)

Created:
4 years, 8 months ago by vabr (Chromium)
Modified:
4 years, 8 months ago
Reviewers:
msw, sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Only create DockedBackgroundWidget as needed. (patchset #6 id:100001 of https://codereview.chromium.org/1882713004/ ) Reason for revert: Broke ash_unittests. More info in http://crbug.com/603419. BUG=603419 Original issue's description: > Only create DockedBackgroundWidget as needed. > > This util widget shows up as a user window shelf icon in mash. > Don't create this widget until it's needed (not used in mash). > > We currently put kShellWindowId_DockedContainer windows in mash::wm::mojom::Container::USER_WINDOWS, which might be okay in the long run, but even if we put them in a separate container, we would need UserWindowControllerImpl to track that container's set of user windows (to show shelf icons); so we would need to single out this widget as a non-user-window somehow. > > We currently don't support docking in mash, but if we choose to use ash's DockedWindowLayoutManager (and DockedBackgroundWidget), we'll need to avoid tracking this background widget as a user window. > > BUG=NONE > TEST="mojo_runner mojo:mash_session" doesn't show a mysterious shelf icon at startup. > R=sky@chromium.org > > Committed: https://crrev.com/14816ec6589c41b5a34f7b534b1c1565c97fe2d7 > Cr-Commit-Position: refs/heads/master@{#387182} TBR=sky@chromium.org,msw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=NONE Committed: https://crrev.com/bc758d44cc3a893ac37fd54c991798aba7175698 Cr-Commit-Position: refs/heads/master@{#387259}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -52 lines) Patch
M ash/wm/dock/docked_window_layout_manager.h View 4 chunks +7 lines, -0 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 21 chunks +49 lines, -52 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vabr (Chromium)
Created Revert of Only create DockedBackgroundWidget as needed.
4 years, 8 months ago (2016-04-14 08:01:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888733002/1
4 years, 8 months ago (2016-04-14 08:01:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888733002/1
4 years, 8 months ago (2016-04-14 08:01:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 08:02:00 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 08:03:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc758d44cc3a893ac37fd54c991798aba7175698
Cr-Commit-Position: refs/heads/master@{#387259}

Powered by Google App Engine
This is Rietveld 408576698