Chromium Code Reviews
DescriptionRevert of Only create DockedBackgroundWidget as needed. (patchset #6 id:100001 of https://codereview.chromium.org/1882713004/ )
Reason for revert:
Broke ash_unittests. More info in http://crbug.com/603419.
BUG=603419
Original issue's description:
> Only create DockedBackgroundWidget as needed.
>
> This util widget shows up as a user window shelf icon in mash.
> Don't create this widget until it's needed (not used in mash).
>
> We currently put kShellWindowId_DockedContainer windows in mash::wm::mojom::Container::USER_WINDOWS, which might be okay in the long run, but even if we put them in a separate container, we would need UserWindowControllerImpl to track that container's set of user windows (to show shelf icons); so we would need to single out this widget as a non-user-window somehow.
>
> We currently don't support docking in mash, but if we choose to use ash's DockedWindowLayoutManager (and DockedBackgroundWidget), we'll need to avoid tracking this background widget as a user window.
>
> BUG=NONE
> TEST="mojo_runner mojo:mash_session" doesn't show a mysterious shelf icon at startup.
> R=sky@chromium.org
>
> Committed: https://crrev.com/14816ec6589c41b5a34f7b534b1c1565c97fe2d7
> Cr-Commit-Position: refs/heads/master@{#387182}
TBR=sky@chromium.org,msw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=NONE
Committed: https://crrev.com/bc758d44cc3a893ac37fd54c991798aba7175698
Cr-Commit-Position: refs/heads/master@{#387259}
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|
||||||||||||||||||||||||||||