Compile src/net for PNaCl

net/cert/crl_set.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/base64.h"
 #include "base/format_macros.h"
 #include "base/json/json_reader.h"
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "crypto/sha2.h"
 #include "net/cert/crl_set.h"
 #include "third_party/zlib/zlib.h"
 
 namespace net {
 
 // Decompress zlib decompressed |in| into |out|. |out_len| is the number of
 // bytes at |out| and must be exactly equal to the size of the decompressed
 // data.
 static bool DecompressZlib(uint8* out, int out_len, base::StringPiece in) {
+#if defined(OS_NACL)
+  NOTIMPLEMENTED();
+  return false;
+#else  // defined(OS_NACL)
   z_stream z;
   memset(&z, 0, sizeof(z));
 
   z.next_in = reinterpret_cast<Bytef*>(const_cast<char*>(in.data()));
   z.avail_in = in.size();
   z.next_out = reinterpret_cast<Bytef*>(out);
   z.avail_out = out_len;
 
   if (inflateInit(&z) != Z_OK)
     return false;
   bool ret = false;
   int r = inflate(&z, Z_FINISH);
   if (r != Z_STREAM_END)
     goto err;
   if (z.avail_in || z.avail_out)
     goto err;
   ret = true;
 
  err:
   inflateEnd(&z);
   return ret;
+#endif  // !defined(OS_NACL)

[Ryan Sleevi, 2014/03/06 22:02:17]

This approach is really ugly here. CRLSets won't work without this Zlib. Why
bother compiling this file at all? Why not provide a stub or exclude it?

[Sergey Ulanov, 2014/03/07 00:19:47]

SSLClientSocket depends on CertVerifier and CertVerifier depends on CRLSet. This
can be solved by making CRLSet a virtual interface and moving and moving CRL
delta parsing to CRLSetImpl. WDYT?

 }
 
 CRLSet::CRLSet()
     : sequence_(0),
       not_after_(0) {
 }
 
 CRLSet::~CRLSet() {
 }
 
@@ skipping 547 matching lines @@
     crl_set->crls_index_by_issuer_[spki] = 0;
   }
 
   if (!serial_number.empty())
     crl_set->crls_[0].second.push_back(serial_number);
 
   return crl_set;
 }
 
 }  // namespace net