 Chromium Code Reviews
 Chromium Code Reviews Issue 1888713002:
  cc: Merge TileTaskRunner to TileTaskWorkerPool.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@rename_tile_task_client
    
  
    Issue 1888713002:
  cc: Merge TileTaskRunner to TileTaskWorkerPool.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@rename_tile_task_client| OLD | NEW | 
|---|---|
| 1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. | 
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be | 
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. | 
| 4 | 4 | 
| 5 #include "cc/raster/tile_task_runner.h" | 5 #include "cc/raster/tile_task.h" | 
| 6 #include "cc/resources/platform_color.h" | |
| 7 | 6 | 
| 8 namespace cc { | 7 namespace cc { | 
| 9 | 8 | 
| 10 TileTask::TileTask(bool supports_concurrent_execution) | 9 TileTask::TileTask(bool supports_concurrent_execution) | 
| 11 : supports_concurrent_execution_(supports_concurrent_execution), | 10 : supports_concurrent_execution_(supports_concurrent_execution), | 
| 12 did_schedule_(false), | 11 did_schedule_(false), | 
| 13 did_complete_(false) {} | 12 did_complete_(false) {} | 
| 14 | 13 | 
| 15 TileTask::TileTask(bool supports_concurrent_execution, | 14 TileTask::TileTask(bool supports_concurrent_execution, | 
| 16 TileTask::Vector* dependencies) | 15 TileTask::Vector* dependencies) | 
| 17 : supports_concurrent_execution_(supports_concurrent_execution), | 16 : supports_concurrent_execution_(supports_concurrent_execution), | 
| 18 dependencies_(std::move(*dependencies)), | 17 dependencies_(std::move(*dependencies)), | 
| 
ericrk
2016/04/20 00:22:29
should we std::swap(dependencies_, dependencies) t
 
prashant.n
2016/04/20 02:04:48
I guess as we are passing vector object created on
 | |
| 19 did_schedule_(false), | 18 did_schedule_(false), | 
| 20 did_complete_(false) {} | 19 did_complete_(false) {} | 
| 21 | 20 | 
| 22 TileTask::~TileTask() { | 21 TileTask::~TileTask() { | 
| 23 DCHECK(!did_schedule_); | 22 DCHECK(!did_schedule_); | 
| 24 DCHECK(!did_run_ || did_complete_); | 23 DCHECK(!did_run_ || did_complete_); | 
| 25 } | 24 } | 
| 26 | 25 | 
| 27 void TileTask::WillSchedule() { | 26 void TileTask::WillSchedule() { | 
| 28 DCHECK(!did_schedule_); | 27 DCHECK(!did_schedule_); | 
| (...skipping 16 matching lines...) Expand all Loading... | |
| 45 DCHECK(did_schedule_); | 44 DCHECK(did_schedule_); | 
| 46 DCHECK(!did_complete_); | 45 DCHECK(!did_complete_); | 
| 47 did_schedule_ = false; | 46 did_schedule_ = false; | 
| 48 did_complete_ = true; | 47 did_complete_ = true; | 
| 49 } | 48 } | 
| 50 | 49 | 
| 51 bool TileTask::HasCompleted() const { | 50 bool TileTask::HasCompleted() const { | 
| 52 return did_complete_; | 51 return did_complete_; | 
| 53 } | 52 } | 
| 54 | 53 | 
| 55 bool TileTaskRunner::ResourceFormatRequiresSwizzle(ResourceFormat format) { | |
| 56 switch (format) { | |
| 57 case RGBA_8888: | |
| 58 case BGRA_8888: | |
| 59 // Initialize resource using the preferred PlatformColor component | |
| 60 // order and swizzle in the shader instead of in software. | |
| 61 return !PlatformColor::SameComponentOrder(format); | |
| 62 case RGBA_4444: | |
| 63 case ETC1: | |
| 64 case ALPHA_8: | |
| 65 case LUMINANCE_8: | |
| 66 case RGB_565: | |
| 67 case RED_8: | |
| 68 case LUMINANCE_F16: | |
| 69 return false; | |
| 70 } | |
| 71 NOTREACHED(); | |
| 72 return false; | |
| 73 } | |
| 74 | |
| 75 } // namespace cc | 54 } // namespace cc | 
| OLD | NEW |