Worker: Rename worker components to clarify what they work for

third_party/WebKit/Source/web/DedicatedWorkerGlobalScopeProxyProviderImpl.h

Index: third_party/WebKit/Source/web/DedicatedWorkerGlobalScopeProxyProviderImpl.h
diff --git a/third_party/WebKit/Source/web/WorkerGlobalScopeProxyProviderImpl.h b/third_party/WebKit/Source/web/DedicatedWorkerGlobalScopeProxyProviderImpl.h
similarity index 62%
rename from third_party/WebKit/Source/web/WorkerGlobalScopeProxyProviderImpl.h
rename to third_party/WebKit/Source/web/DedicatedWorkerGlobalScopeProxyProviderImpl.h
index d24ef0601fbd82a662abdcea98adb90581bfb51e..c8a50bb6c494bf529786c41c8c5b15a65e722a9e 100644
--- a/third_party/WebKit/Source/web/WorkerGlobalScopeProxyProviderImpl.h
+++ b/third_party/WebKit/Source/web/DedicatedWorkerGlobalScopeProxyProviderImpl.h
@@ -28,36 +28,35 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef WorkerGlobalScopeProxyProviderImpl_h
-#define WorkerGlobalScopeProxyProviderImpl_h
+#ifndef DedicatedWorkerGlobalScopeProxyProviderImpl_h
+#define DedicatedWorkerGlobalScopeProxyProviderImpl_h
 
-#include "core/workers/WorkerGlobalScopeProxyProvider.h"
+#include "core/workers/DedicatedWorkerGlobalScopeProxyProvider.h"
 #include "wtf/Noncopyable.h"
 #include "wtf/PassOwnPtr.h"
 
 namespace blink {
 
-class Worker;
-class WorkerGlobalScopeProxy;
-
-class WorkerGlobalScopeProxyProviderImpl final : public GarbageCollectedFinalized<WorkerGlobalScopeProxyProviderImpl>, public WorkerGlobalScopeProxyProvider {
-    USING_GARBAGE_COLLECTED_MIXIN(WorkerGlobalScopeProxyProviderImpl);
-    WTF_MAKE_NONCOPYABLE(WorkerGlobalScopeProxyProviderImpl);
+class DedicatedWorkerGlobalScopeProxyProviderImpl final
+    : public GarbageCollectedFinalized<DedicatedWorkerGlobalScopeProxyProviderImpl>
+    , public DedicatedWorkerGlobalScopeProxyProvider {
+    USING_GARBAGE_COLLECTED_MIXIN(DedicatedWorkerGlobalScopeProxyProviderImpl);
+    WTF_MAKE_NONCOPYABLE(DedicatedWorkerGlobalScopeProxyProviderImpl);
 public:
-    static WorkerGlobalScopeProxyProviderImpl* create()
+    static DedicatedWorkerGlobalScopeProxyProviderImpl* create()
     {
-        return new WorkerGlobalScopeProxyProviderImpl();
+        return new DedicatedWorkerGlobalScopeProxyProviderImpl();
     }
 
-    ~WorkerGlobalScopeProxyProviderImpl() override { }
-    WorkerGlobalScopeProxy* createWorkerGlobalScopeProxy(Worker*) override;
+    ~DedicatedWorkerGlobalScopeProxyProviderImpl() override { }
+    InProcessWorkerGlobalScopeProxy* createDedicatedWorkerGlobalScopeProxy(Worker*) override;

[kinuko, 2016/04/19 04:44:20]

nit: createDedicatedWorkerGSP returning InProcessWorkerGSP feels slightly weird,
while it's probably ok...

[nhiroki, 2016/04/19 06:15:05]

Agreed. I come up with 2 options here:

  a.) Returns "DedicatedWorkerMessagingProxy" instead of
"InProcessWorkerGlobalScopeProxy".
  b.) Revert the function name change, that is, "createWorkerGlobalScopeProxy".

The option (a) looks also weird because the type of return value does not match
with the class and function names. The option (b) looks more natural than the
current patch and the option a.), so I chose the option (b). I hope that the
following CLs can fix this twisted naming...

Done.

 
-    DEFINE_INLINE_VIRTUAL_TRACE() { WorkerGlobalScopeProxyProvider::trace(visitor); }
+    DEFINE_INLINE_VIRTUAL_TRACE() { DedicatedWorkerGlobalScopeProxyProvider::trace(visitor); }
 
 private:
-    WorkerGlobalScopeProxyProviderImpl() { }
+    DedicatedWorkerGlobalScopeProxyProviderImpl() { }
 };
 
 } // namespace blink
 
-#endif // WorkerGlobalScopeProxyProviderImpl_h
+#endif // DedicatedWorkerGlobalScopeProxyProviderImpl_h