Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1888683002: Revert of Turn on FRAMEBUFFER_SRGB on desktop GL. (Closed)

Created:
4 years, 8 months ago by piman
Modified:
4 years, 8 months ago
CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit), bajones
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Turn on FRAMEBUFFER_SRGB on desktop GL. (patchset #2 id:20001 of https://codereview.chromium.org/1886773005/ ) Reason for revert: Seems to break rendering on linux - see crbug.com/603371 Original issue's description: > Turn on FRAMEBUFFER_SRGB on desktop GL. > > For ES3, it is on by default. > > BUG=429053 > TEST=conformance2/reading/read-pixels-from-fbo.html > R=piman@chromium.org > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel > NOTRY=true > > Committed: https://crrev.com/2d1321caf2011f5bd4aa144915ba5e6c03f8a014 > Cr-Commit-Position: refs/heads/master@{#387215} TBR=kbr@chromium.org,zmo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=429053 Committed: https://crrev.com/825f70696dc7ddaedaa9c74c3eb3a25c1d53e399 Cr-Commit-Position: refs/heads/master@{#387227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
piman
Created Revert of Turn on FRAMEBUFFER_SRGB on desktop GL.
4 years, 8 months ago (2016-04-14 03:32:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888683002/1
4 years, 8 months ago (2016-04-14 03:33:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 03:33:49 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 03:35:50 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/825f70696dc7ddaedaa9c74c3eb3a25c1d53e399
Cr-Commit-Position: refs/heads/master@{#387227}

Powered by Google App Engine
This is Rietveld 408576698