Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h

Issue 1888673002: [DevTools] Move style sheet content storage from css agent to resource loader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h
index a3bdb1bca01dd868b0b9e75fdf4939281cb62f33..b5072fc478f46ac34c88e51d71a4972756d80dad 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h
@@ -53,6 +53,7 @@ class Element;
class InspectedFrames;
class InspectorFrontend;
class InspectorResourceAgent;
+class InspectorResourceContainer;
class InspectorResourceContentLoader;
class MediaList;
class Node;
@@ -99,9 +100,9 @@ public:
static CSSStyleRule* asCSSStyleRule(CSSRule*);
static CSSMediaRule* asCSSMediaRule(CSSRule*);
- static InspectorCSSAgent* create(InspectorDOMAgent* domAgent, InspectedFrames* inspectedFrames, InspectorResourceAgent* resourceAgent, InspectorResourceContentLoader* resourceContentLoader)
+ static InspectorCSSAgent* create(InspectorDOMAgent* domAgent, InspectedFrames* inspectedFrames, InspectorResourceAgent* resourceAgent, InspectorResourceContentLoader* resourceContentLoader, InspectorResourceContainer* resourceContainer)
{
- return new InspectorCSSAgent(domAgent, inspectedFrames, resourceAgent, resourceContentLoader);
+ return new InspectorCSSAgent(domAgent, inspectedFrames, resourceAgent, resourceContentLoader, resourceContainer);
}
static void collectAllDocumentStyleSheets(Document*, HeapVector<Member<CSSStyleSheet>>&);
@@ -120,12 +121,6 @@ public:
void activeStyleSheetsUpdated(Document*);
void documentDetached(Document*);
- void addEditedStyleSheet(const String& url, const String& content);
- bool getEditedStyleSheet(const String& url, String* content);
-
- void addEditedStyleElement(int backendNodeId, const String& content);
- bool getEditedStyleElement(int backendNodeId, String* content);
-
void enable(ErrorString*, PassOwnPtr<EnableCallback>) override;
void disable(ErrorString*) override;
void getMatchedStylesForNode(ErrorString*, int nodeId, Maybe<protocol::CSS::CSSStyle>* inlineStyle, Maybe<protocol::CSS::CSSStyle>* attributesStyle, Maybe<protocol::Array<protocol::CSS::RuleMatch>>* matchedCSSRules, Maybe<protocol::Array<protocol::CSS::PseudoElementMatches>>*, Maybe<protocol::Array<protocol::CSS::InheritedStyleEntry>>*, Maybe<protocol::Array<protocol::CSS::CSSKeyframesRule>>*) override;
@@ -165,7 +160,7 @@ private:
static void collectStyleSheets(CSSStyleSheet*, HeapVector<Member<CSSStyleSheet>>&);
- InspectorCSSAgent(InspectorDOMAgent*, InspectedFrames*, InspectorResourceAgent*, InspectorResourceContentLoader*);
+ InspectorCSSAgent(InspectorDOMAgent*, InspectedFrames*, InspectorResourceAgent*, InspectorResourceContentLoader*, InspectorResourceContainer*);
typedef HeapHashMap<String, Member<InspectorStyleSheet>> IdToInspectorStyleSheet;
typedef HeapHashMap<String, Member<InspectorStyleSheetForInlineStyle>> IdToInspectorStyleSheetForInlineStyle;
@@ -216,6 +211,7 @@ private:
Member<InspectedFrames> m_inspectedFrames;
Member<InspectorResourceAgent> m_resourceAgent;
Member<InspectorResourceContentLoader> m_resourceContentLoader;
+ Member<InspectorResourceContainer> m_resourceContainer;
IdToInspectorStyleSheet m_idToInspectorStyleSheet;
IdToInspectorStyleSheetForInlineStyle m_idToInspectorStyleSheetForInlineStyle;
@@ -229,8 +225,6 @@ private:
NodeIdToForcedPseudoState m_nodeIdToForcedPseudoState;
Member<CSSStyleSheet> m_inspectorUserAgentStyleSheet;
- HashMap<String, String> m_editedStyleSheets;
- HashMap<int, String> m_editedStyleElements;
bool m_creatingViaInspectorStyleSheet;
bool m_isSettingStyleSheetText;
« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698