Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1888613002: cc: Ensure to reapply a shared canvas transform to image hijack canvas. (Closed)

Created:
4 years, 8 months ago by vmpstr
Modified:
4 years, 8 months ago
Reviewers:
enne (OOO)
CC:
boliu, cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Ensure to reapply a shared canvas transform to image hijack canvas. When we wrap a shared canvas in an image hijack canvas, it might already have a transform applied to it. This transform is used to compute the clip bounds for the canvas. However, since we're wrapping the canvas into an image hijack canvas, its clip bounds can be different, since it does not know about the transform on the raster canvas. The fix to this is to ensure to apply the matrix to the hijack canvas before attaching the raster canvas. R=enne BUG=601913 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7cb1a3b0e0aec2fad7b3f59b789cff12efa3dd12 Cr-Commit-Position: refs/heads/master@{#387390}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
M cc/playback/raster_source.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M cc/playback/raster_source_unittest.cc View 2 chunks +60 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
vmpstr
Please take a look.
4 years, 8 months ago (2016-04-13 23:34:24 UTC) #2
enne (OOO)
lgtm
4 years, 8 months ago (2016-04-14 00:27:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888613002/20001
4 years, 8 months ago (2016-04-14 18:22:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-14 19:17:53 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 19:19:13 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7cb1a3b0e0aec2fad7b3f59b789cff12efa3dd12
Cr-Commit-Position: refs/heads/master@{#387390}

Powered by Google App Engine
This is Rietveld 408576698