Add CdmFileIOProvider interface for use by cdm_adapter

Add CdmFileIOProvider interface for use by cdm_adapter

When cdm_adapter is created an CdmFileIOProvider object is provided
that allows the CDM to access files. Includes a simple implementation
that does nothing for testing purposes (since none of the tests rely
on having access to a filesystem).

BUG=479923
TEST=media_unittests pass

Committed: https://crrev.com/377a54c9058bdbdcf86edcac49ff638f96fddb68
Cr-Commit-Position: refs/heads/master@{#388648}

[jrummell, 2016-04-13 22:15:00]

jrummell@chromium.org changed reviewers:
+ xhwang@chromium.org

[jrummell, 2016-04-13 22:15:00]

PTAL

[xhwang, 2016-04-14 06:46:31]

https://chromiumcodereview.appspot.com/1888603002/diff/1/media/cdm/cdm_file_i...
File media/cdm/cdm_file_io_provider.h (right):

https://chromiumcodereview.appspot.com/1888603002/diff/1/media/cdm/cdm_file_i...
media/cdm/cdm_file_io_provider.h:27: virtual cdm::FileIO*
CreateFileIO(cdm::FileIOClient* client) = 0;
Since this interface only has one Create* method, will it work (and be simpler)
if we just pass a callback into CdmAdapter?

e.g.

Callback<unique_ptr<cdm::FileIO>(client)>

[jrummell, 2016-04-14 22:02:56]

Updated to pass a Callback. Unfortunately cdm::FileIO has a protected
destructor, so had to add a simple wrapper class so unique_ptr<> would work.

https://codereview.chromium.org/1888603002/diff/1/media/cdm/cdm_file_io_provi...
File media/cdm/cdm_file_io_provider.h (right):

https://codereview.chromium.org/1888603002/diff/1/media/cdm/cdm_file_io_provi...
media/cdm/cdm_file_io_provider.h:27: virtual cdm::FileIO*
CreateFileIO(cdm::FileIOClient* client) = 0;
On 2016/04/14 06:46:31, xhwang wrote:
> Since this interface only has one Create* method, will it work (and be
simpler)
> if we just pass a callback into CdmAdapter?
> 
> e.g.
> 
> Callback<unique_ptr<cdm::FileIO>(client)>

Done.

[xhwang, 2016-04-18 21:09:23]

lgtm with some nits

https://chromiumcodereview.appspot.com/1888603002/diff/20001/media/cdm/cdm_ad...
File media/cdm/cdm_adapter.cc (right):

https://chromiumcodereview.appspot.com/1888603002/diff/20001/media/cdm/cdm_ad...
media/cdm/cdm_adapter.cc:902: // to release it.
nit: Move this comment to right above the "return".

https://chromiumcodereview.appspot.com/1888603002/diff/20001/media/cdm/cdm_ad...
File media/cdm/cdm_adapter.h (right):

https://chromiumcodereview.appspot.com/1888603002/diff/20001/media/cdm/cdm_ad...
media/cdm/cdm_adapter.h:45: using CdmFileIOProviderCB =
The naming is a bit odd since the callback does create a "Provider". 

Typically we call this a Create*CB, e.g. CreateCdmFileIOCB:

https://code.google.com/p/chromium/codesearch#search/&q=Create.*CB&sq=package...

https://chromiumcodereview.appspot.com/1888603002/diff/20001/media/cdm/cdm_fi...
File media/cdm/cdm_file_io.h (right):

https://chromiumcodereview.appspot.com/1888603002/diff/20001/media/cdm/cdm_fi...
media/cdm/cdm_file_io.h:14: class MEDIA_EXPORT CdmFileIO : public cdm::FileIO {
Add a comment why we need this?

[jrummell, 2016-04-19 23:57:06]

Patchset #3 (id:40001) has been deleted

[jrummell, 2016-04-19 23:59:29]

Thanks for the reviews.

https://codereview.chromium.org/1888603002/diff/20001/media/cdm/cdm_adapter.cc
File media/cdm/cdm_adapter.cc (right):

https://codereview.chromium.org/1888603002/diff/20001/media/cdm/cdm_adapter.c...
media/cdm/cdm_adapter.cc:902: // to release it.
On 2016/04/18 21:09:22, xhwang wrote:
> nit: Move this comment to right above the "return".

Done.

https://codereview.chromium.org/1888603002/diff/20001/media/cdm/cdm_adapter.h
File media/cdm/cdm_adapter.h (right):

https://codereview.chromium.org/1888603002/diff/20001/media/cdm/cdm_adapter.h...
media/cdm/cdm_adapter.h:45: using CdmFileIOProviderCB =
On 2016/04/18 21:09:22, xhwang wrote:
> The naming is a bit odd since the callback does create a "Provider". 
> 
> Typically we call this a Create*CB, e.g. CreateCdmFileIOCB:
> 
>
https://code.google.com/p/chromium/codesearch#search/&q=Create.*CB&sq=package...

Done.

https://codereview.chromium.org/1888603002/diff/20001/media/cdm/cdm_file_io.h
File media/cdm/cdm_file_io.h (right):

https://codereview.chromium.org/1888603002/diff/20001/media/cdm/cdm_file_io.h...
media/cdm/cdm_file_io.h:14: class MEDIA_EXPORT CdmFileIO : public cdm::FileIO {
On 2016/04/18 21:09:23, xhwang wrote:
> Add a comment why we need this?

Done.

[jrummell, 2016-04-19 23:59:32]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2016-04-19 23:59:33]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1888603002/#ps60001
(title: "nits")

[commit-bot: I haz the power, 2016-04-20 00:00:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1888603002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1888603002/60001

[commit-bot: I haz the power, 2016-04-20 01:16:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 01:16:06]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[jrummell, 2016-04-20 23:09:21]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2016-04-20 23:09:21]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1888603002/#ps80001
(title: "fix Win compile issue")

[commit-bot: I haz the power, 2016-04-20 23:10:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1888603002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1888603002/80001

[commit-bot: I haz the power, 2016-04-21 01:13:12]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-04-22 19:29:45]

Description was changed from

==========
Add CdmFileIOProvider interface for use by cdm_adapter

When cdm_adapter is created an CdmFileIOProvider object is provided
that allows the CDM to access files. Includes a simple implementation
that does nothing for testing purposes (since none of the tests rely
on having access to a filesystem).

BUG=479923
TEST=media_unittests pass
==========

to

==========
Add CdmFileIOProvider interface for use by cdm_adapter

When cdm_adapter is created an CdmFileIOProvider object is provided
that allows the CDM to access files. Includes a simple implementation
that does nothing for testing purposes (since none of the tests rely
on having access to a filesystem).

BUG=479923
TEST=media_unittests pass

Committed: https://crrev.com/377a54c9058bdbdcf86edcac49ff638f96fddb68
Cr-Commit-Position: refs/heads/master@{#388648}
==========

[commit-bot: I haz the power, 2016-04-22 19:29:46]

Patchset 4 (id:??) landed as
https://crrev.com/377a54c9058bdbdcf86edcac49ff638f96fddb68
Cr-Commit-Position: refs/heads/master@{#388648}