[PDF] Use SkTypeface::countGlyphs instead of getAdvancedTypefaceMetrics

[PDF] Use SkTypeface::countGlyphs instead of getAdvancedTypefaceMetrics

BUG=1088
Committed: http://code.google.com/p/skia/source/detail?r=10063

[bungeman-skia, 2013-07-12 19:30:41]

https://codereview.chromium.org/18886005/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/18886005/diff/1/src/pdf/SkPDFDevice.cpp#newco...
src/pdf/SkPDFDevice.cpp:108: return typeface->countGlyphs() + 1;
did you mean -1? If there are 4 glyphs, and they're numbered from 0, then the
last one is 3.

[vandebo (ex-Chrome), 2013-07-12 19:34:08]

https://codereview.chromium.org/18886005/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/18886005/diff/1/src/pdf/SkPDFDevice.cpp#newco...
src/pdf/SkPDFDevice.cpp:108: return typeface->countGlyphs() + 1;
On 2013/07/12 19:30:41, bungeman1 wrote:
> did you mean -1? If there are 4 glyphs, and they're numbered from 0, then the
> last one is 3.

Indeed. Fixed.

[bungeman-skia, 2013-07-12 19:38:10]

lgtm at Patch Set 2.

[commit-bot: I haz the power, 2013-07-12 20:37:23]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/vandebo@chromium.org/18886005/5001

[commit-bot: I haz the power, 2013-07-13 17:24:31]

Change committed as 10063

[robertphillips, 2013-07-13 18:34:26]

onCountGlyphs isn't implemented on Windows so this CL was causing crashes
(http://108.170.217.252:10117/builders/Test-Win7-ShuttleA-HD2000-x86-Debug/bui...).

It was reverted in r10064.

[reed1, 2013-07-17 19:43:20]

Dang. Have we fixed this now (i.e. implemented this for windows?)

[vandebo (ex-Chrome), 2013-07-17 19:51:07]

On 2013/07/17 19:43:20, reed1 wrote:
> Dang. Have we fixed this now (i.e. implemented this for windows?)

I think so, I just resubmitted the CL for review.