Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1888593003: Revert "- Use a hash table to canonicalize instances/arrays to avoid having to iterate over a linea… (Closed)

Created:
4 years, 8 months ago by siva
Modified:
4 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "- Use a hash table to canonicalize instances/arrays to avoid having to iterate over a linear list and search for canonical instances." This reverts commit 95a2b02a9e74714d7e9835e7af0fd85f694a4d2d. Once the tree shaker in precompiled code is fixed to treat the constants array in a class as a hash table this CL can be re-applied. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/8ce7b6291a84512956f5c09a62f72edaa89861eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -267 lines) Patch
M runtime/lib/integers.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/class_finalizer.cc View 3 chunks +10 lines, -12 lines 0 comments Download
M runtime/vm/dart_entry.cc View 4 chunks +9 lines, -15 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 4 chunks +5 lines, -9 lines 0 comments Download
M runtime/vm/object.h View 14 chunks +12 lines, -44 lines 0 comments Download
M runtime/vm/object.cc View 20 chunks +80 lines, -177 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +1 line, -4 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 8 months ago (2016-04-14 01:44:22 UTC) #2
rmacnak
lgtm
4 years, 8 months ago (2016-04-14 01:46:29 UTC) #3
siva
4 years, 8 months ago (2016-04-14 01:49:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8ce7b6291a84512956f5c09a62f72edaa89861eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698