|
|
Chromium Code Reviews
DescriptionFix segment fault issue bring by last cl https://codereview.chromium.org/1857213004/
Fix segment fault issue related to launcher context menu.
BUG=602918
Committed: https://crrev.com/6ebd2ffdf5c5973d95632e25e544cde378828bda
Cr-Commit-Position: refs/heads/master@{#387013}
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
The CQ bit was checked by lgcheng@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888513002/1
Description was changed from ========== Fix segment fault issue bring by last cl. Fix segment fault issue related to launcher context menu. BUG= 602918 ========== to ========== Fix segment fault issue bring by last cl. Fix segment fault issue related to launcher context menu. BUG= 602918 ==========
lgcheng@google.com changed reviewers: + stevenjb@chromium.org
Hi Steven, PTAL at this patch. It turns out there is actually a bug in my last patch https://codereview.chromium.org/1857213004/ which can cause segment fault. This patch fix that issue. Thanks
Description was changed from ========== Fix segment fault issue bring by last cl. Fix segment fault issue related to launcher context menu. BUG= 602918 ========== to ========== Fix segment fault issue bring by last cl https://codereview.chromium.org/1857213004/ Fix segment fault issue related to launcher context menu. BUG= 602918 ==========
lgcheng@google.com changed reviewers: + yiyix@chromium.org
Adding Yi so that you can get update in time.
lgtm
On 2016/04/13 16:54:39, stevenjb wrote: > lgtm Thanks for review!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by lgcheng@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888513002/1
Message was sent while issue was closed.
Description was changed from ========== Fix segment fault issue bring by last cl https://codereview.chromium.org/1857213004/ Fix segment fault issue related to launcher context menu. BUG= 602918 ========== to ========== Fix segment fault issue bring by last cl https://codereview.chromium.org/1857213004/ Fix segment fault issue related to launcher context menu. BUG= 602918 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix segment fault issue bring by last cl https://codereview.chromium.org/1857213004/ Fix segment fault issue related to launcher context menu. BUG= 602918 ========== to ========== Fix segment fault issue bring by last cl https://codereview.chromium.org/1857213004/ Fix segment fault issue related to launcher context menu. BUG= 602918 Committed: https://crrev.com/6ebd2ffdf5c5973d95632e25e544cde378828bda Cr-Commit-Position: refs/heads/master@{#387013} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6ebd2ffdf5c5973d95632e25e544cde378828bda Cr-Commit-Position: refs/heads/master@{#387013} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
