Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1888513002: Fix segment fault issue bring by last cl. (Closed)

Created:
4 years, 8 months ago by lgcheng
Modified:
4 years, 8 months ago
Reviewers:
stevenjb, yiyix
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix segment fault issue bring by last cl https://codereview.chromium.org/1857213004/ Fix segment fault issue related to launcher context menu. BUG=602918 Committed: https://crrev.com/6ebd2ffdf5c5973d95632e25e544cde378828bda Cr-Commit-Position: refs/heads/master@{#387013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888513002/1
4 years, 8 months ago (2016-04-13 16:20:08 UTC) #2
lgcheng
Hi Steven, PTAL at this patch. It turns out there is actually a bug in ...
4 years, 8 months ago (2016-04-13 16:25:53 UTC) #5
lgcheng
Adding Yi so that you can get update in time.
4 years, 8 months ago (2016-04-13 16:38:22 UTC) #8
stevenjb
lgtm
4 years, 8 months ago (2016-04-13 16:54:39 UTC) #9
lgcheng
On 2016/04/13 16:54:39, stevenjb wrote: > lgtm Thanks for review!
4 years, 8 months ago (2016-04-13 16:56:42 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 17:10:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888513002/1
4 years, 8 months ago (2016-04-13 17:11:59 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 17:18:21 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 17:19:23 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ebd2ffdf5c5973d95632e25e544cde378828bda
Cr-Commit-Position: refs/heads/master@{#387013}

Powered by Google App Engine
This is Rietveld 408576698