Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1888503002: gyp-win-tool: Let LinkWrapper only transmogrify / when the host platform is Windows. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

gyp-win-tool: Let LinkWrapper only transmogrify / when the host platform is Windows. BUG=495204 R=scottmg@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/f9ac7a9ba1c461ec52dc95c3c892743365af31b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M pylib/gyp/win_tool.py View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Nico
4 years, 8 months ago (2016-04-13 16:04:18 UTC) #2
scottmg
lgtm
4 years, 8 months ago (2016-04-13 17:13:51 UTC) #3
Nico
4 years, 8 months ago (2016-04-13 18:18:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f9ac7a9ba1c461ec52dc95c3c892743365af31b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698