Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 1888473003: Simplify gamma-correctness for text rendering. (Closed)

Created:
4 years, 8 months ago by Brian Osman
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Simplify gamma-correctness for text rendering. Just use the DC flag, independent of the destination pixel config or the special output override flag (which is only to be used internally be special effects that will never hit this code path.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1888473003 Committed: https://skia.googlesource.com/skia/+/5280dcbae3affd73be5d5e0ff3db8823e26901e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -14 lines) Patch
M src/gpu/text/GrAtlasTextBlob.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 4 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888473003/1
4 years, 8 months ago (2016-04-13 21:25:22 UTC) #3
Brian Osman
4 years, 8 months ago (2016-04-13 21:25:27 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 21:37:02 UTC) #7
jvanverth1
lgtm
4 years, 8 months ago (2016-04-13 21:45:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888473003/1
4 years, 8 months ago (2016-04-14 13:01:44 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 13:03:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5280dcbae3affd73be5d5e0ff3db8823e26901e6

Powered by Google App Engine
This is Rietveld 408576698