Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1888453006: Revert of cc: Add a main thread LayerListIterator (Closed)

Created:
4 years, 8 months ago by rjkroege
Modified:
4 years, 8 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Add a main thread LayerListIterator (patchset #3 id:40001 of https://codereview.chromium.org/1887703002/ ) Reason for revert: Per: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/47790, I think that this CL breaks cc unit tests. [ RUN ] LayerTreeHostCopyRequestTestLostOutputSurface.RunMultiThread_DirectRenderer c:\b\build\slave\win_builder__dbg_\build\src\cc\test\layer_tree_test.cc(899): error: Failed Test timed out [ FAILED ] LayerTreeHostCopyRequestTestLostOutputSurface.RunMultiThread_DirectRenderer (5006 ms) Original issue's description: > cc: Add a main thread LayerListIterator > > Make LayerListIterator a template class for Layer and LayerImpl. > > Add tests for LayerListIterator<Layer>. > > BUG=603181 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8 > Cr-Commit-Position: refs/heads/master@{#387422} TBR=ajuma@chromium.org,vollick@chromium.org,jaydasika@chromium.org,sunxd@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=603181 Committed: https://crrev.com/ad45a5f2de581606e585b21a120f61a159de4550 Cr-Commit-Position: refs/heads/master@{#387474}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -285 lines) Patch
M cc/layers/layer_list_iterator.h View 2 chunks +10 lines, -15 lines 0 comments Download
M cc/layers/layer_list_iterator.cc View 2 chunks +31 lines, -44 lines 0 comments Download
M cc/layers/layer_list_iterator_unittest.cc View 6 chunks +9 lines, -186 lines 0 comments Download
M cc/trees/layer_tree_host.h View 2 chunks +0 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +14 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rjkroege
Created Revert of cc: Add a main thread LayerListIterator
4 years, 8 months ago (2016-04-14 23:42:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888453006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888453006/1
4 years, 8 months ago (2016-04-14 23:43:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 23:43:58 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 23:45:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad45a5f2de581606e585b21a120f61a159de4550
Cr-Commit-Position: refs/heads/master@{#387474}

Powered by Google App Engine
This is Rietveld 408576698