Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1888423002: Walk through files in parse_llvm_coverage.py instead of using 'git ls-files' (Closed)

Created:
4 years, 8 months ago by rmistry
Modified:
4 years, 8 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Walk through files in parse_llvm_coverage.py instead of using 'git ls-files' The script will be executed on a swarming bot where we do not want to isolate .git directories. BUG=skia:5159 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1888423002 NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/5f80e8cb7cfb83a69d478861f01ea8e965fcd448

Patch Set 1 : Initial upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M tools/parse_llvm_coverage.py View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888423002/1
4 years, 8 months ago (2016-04-15 14:15:52 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 14:33:44 UTC) #5
rmistry
4 years, 8 months ago (2016-04-15 14:34:20 UTC) #7
borenet
LGTM
4 years, 8 months ago (2016-04-15 15:38:45 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888423002/1
4 years, 8 months ago (2016-04-18 10:51:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888423002/1
4 years, 8 months ago (2016-04-18 11:14:56 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 11:18:58 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5f80e8cb7cfb83a69d478861f01ea8e965fcd448

Powered by Google App Engine
This is Rietveld 408576698