Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 18884003: Add option to pnacl-abicheck to handle pnacl bitcode (Closed)

Created:
7 years, 5 months ago by Derek Schuff
Modified:
7 years, 5 months ago
Reviewers:
Karl
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master
Visibility:
Public.

Description

Add option to pnacl-abicheck to handle pnacl bitcode This allows running the utility on finalized/frozen pexes. R=kschimpf@google.com BUG=none Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=f5dd243

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M include/llvm/IRReader/IRReader.h View 1 chunk +2 lines, -1 line 0 comments Download
M tools/pnacl-abicheck/CMakeLists.txt View 1 chunk +1 line, -1 line 0 comments Download
M tools/pnacl-abicheck/LLVMBuild.txt View 1 chunk +1 line, -1 line 0 comments Download
M tools/pnacl-abicheck/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M tools/pnacl-abicheck/pnacl-abicheck.cpp View 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Derek Schuff
7 years, 5 months ago (2013-07-09 22:54:58 UTC) #1
Karl
lgtm
7 years, 5 months ago (2013-07-10 15:04:09 UTC) #2
Derek Schuff
7 years, 5 months ago (2013-07-10 16:08:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as rf5dd243 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698