Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18884002: Make editing/deleting/delete-br-00[1-7].html platform independent (Closed)

Created:
7 years, 5 months ago by yosin_UTC9
Modified:
7 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

This patch makes editing/deleting/delete-br-00[1-7].html platform independent and unifies them into one test, delete-br-001.html. BUG=n/a R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -947 lines) Patch
M LayoutTests/editing/deleting/delete-br-001.html View 1 chunk +31 lines, -30 lines 0 comments Download
M LayoutTests/editing/deleting/delete-br-001-expected.txt View 1 chunk +22 lines, -43 lines 0 comments Download
D LayoutTests/editing/deleting/delete-br-002.html View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/editing/deleting/delete-br-002-expected.txt View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/editing/deleting/delete-br-003.html View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/editing/deleting/delete-br-003-expected.txt View 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/editing/deleting/delete-br-004.html View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/editing/deleting/delete-br-004-expected.txt View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/editing/deleting/delete-br-005.html View 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/editing/deleting/delete-br-005-expected.txt View 1 chunk +0 lines, -49 lines 0 comments Download
D LayoutTests/editing/deleting/delete-br-006.html View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/editing/deleting/delete-br-006-expected.txt View 1 chunk +0 lines, -52 lines 0 comments Download
D LayoutTests/editing/deleting/delete-br-007.html View 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/editing/deleting/delete-br-007-expected.txt View 1 chunk +0 lines, -47 lines 0 comments Download
D LayoutTests/platform/linux/editing/deleting/delete-br-001-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/editing/deleting/delete-br-002-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/editing/deleting/delete-br-003-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/editing/deleting/delete-br-004-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/editing/deleting/delete-br-005-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/editing/deleting/delete-br-006-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/editing/deleting/delete-br-007-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/editing/deleting/delete-br-001-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/editing/deleting/delete-br-002-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/editing/deleting/delete-br-003-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/editing/deleting/delete-br-004-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/editing/deleting/delete-br-005-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/editing/deleting/delete-br-006-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/editing/deleting/delete-br-007-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/editing/deleting/delete-br-001-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/editing/deleting/delete-br-002-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/editing/deleting/delete-br-003-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/editing/deleting/delete-br-004-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/editing/deleting/delete-br-005-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/editing/deleting/delete-br-006-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/editing/deleting/delete-br-007-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/editing/deleting/delete-br-001-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/editing/deleting/delete-br-001-expected.txt View 1 chunk +0 lines, -43 lines 0 comments Download
D LayoutTests/platform/win/editing/deleting/delete-br-002-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/editing/deleting/delete-br-002-expected.txt View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/platform/win/editing/deleting/delete-br-003-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/editing/deleting/delete-br-003-expected.txt View 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/platform/win/editing/deleting/delete-br-004-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/editing/deleting/delete-br-004-expected.txt View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/platform/win/editing/deleting/delete-br-005-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/editing/deleting/delete-br-005-expected.txt View 1 chunk +0 lines, -49 lines 0 comments Download
D LayoutTests/platform/win/editing/deleting/delete-br-006-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/editing/deleting/delete-br-006-expected.txt View 1 chunk +0 lines, -52 lines 0 comments Download
D LayoutTests/platform/win/editing/deleting/delete-br-007-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/editing/deleting/delete-br-007-expected.txt View 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yosin_UTC9
Hi, Could you review this patch? Thanks in advance. P.S. This patch is preparation of ...
7 years, 5 months ago (2013-07-09 08:43:16 UTC) #1
tkent
lgtm
7 years, 5 months ago (2013-07-09 21:37:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/18884002/1
7 years, 5 months ago (2013-07-09 21:38:02 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=15563
7 years, 5 months ago (2013-07-09 22:41:21 UTC) #4
yosin_UTC9
7 years, 5 months ago (2013-07-10 01:26:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 manually as r153832 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698