Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: tests/compiler/dart2js/serialization_test.dart

Issue 1888393002: Fix some issues in element serialization. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Fix comment. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/serialization/modelz.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/serialization_test.dart
diff --git a/tests/compiler/dart2js/serialization_test.dart b/tests/compiler/dart2js/serialization_test.dart
index c25fadd42838d4bebefad15debdca25343e14268..9e6457e473e05b48e9d8b189f5f57bc0c44671ca 100644
--- a/tests/compiler/dart2js/serialization_test.dart
+++ b/tests/compiler/dart2js/serialization_test.dart
@@ -479,6 +479,10 @@ class ElementPropertyEquivalence extends BaseElementVisitor<dynamic, Element> {
checkElementProperties);
check(element1, element2, 'isOperator',
element1.isOperator, element2.isOperator);
+ check(
+ element1, element2, 'asyncMarker',
+ element1.asyncMarker,
+ element2.asyncMarker);
checkElementIdentities(
element1, element2, 'library',
@@ -489,6 +493,44 @@ class ElementPropertyEquivalence extends BaseElementVisitor<dynamic, Element> {
checkElementIdentities(
element1, element2, 'enclosingClass',
element1.enclosingClass, element2.enclosingClass);
+
+ check(
+ element1, element2, 'functionSignature.type',
+ element1.functionSignature.type,
+ element2.functionSignature.type,
+ areTypesEquivalent);
+ checkElementLists(
+ element1, element2, 'functionSignature.requiredParameters',
+ element1.functionSignature.requiredParameters,
+ element2.functionSignature.requiredParameters);
+ checkElementLists(
+ element1, element2, 'functionSignature.optionalParameters',
+ element1.functionSignature.optionalParameters,
+ element2.functionSignature.optionalParameters);
+ check(
+ element1, element2, 'functionSignature.requiredParameterCount',
+ element1.functionSignature.requiredParameterCount,
+ element2.functionSignature.requiredParameterCount);
+ check(
+ element1, element2, 'functionSignature.optionalParameterCount',
+ element1.functionSignature.optionalParameterCount,
+ element2.functionSignature.optionalParameterCount);
+ check(
+ element1, element2, 'functionSignature.optionalParametersAreNamed',
+ element1.functionSignature.optionalParametersAreNamed,
+ element2.functionSignature.optionalParametersAreNamed);
+ check(
+ element1, element2, 'functionSignature.hasOptionalParameters',
+ element1.functionSignature.hasOptionalParameters,
+ element2.functionSignature.hasOptionalParameters);
+ check(
+ element1, element2, 'functionSignature.parameterCount',
+ element1.functionSignature.parameterCount,
+ element2.functionSignature.parameterCount);
+ checkElementLists(
+ element1, element2, 'functionSignature.orderedOptionalParameters',
+ element1.functionSignature.orderedOptionalParameters,
+ element2.functionSignature.orderedOptionalParameters);
}
@override
@@ -585,6 +627,9 @@ class ElementPropertyEquivalence extends BaseElementVisitor<dynamic, Element> {
check(
element1, element2, 'isNamed',
element1.isNamed, element2.isNamed);
+ check(
+ element1, element2, 'isFinal',
+ element1.isFinal, element2.isFinal);
check(element1, element2, 'name', element1.name, element2.name);
if (element1.isOptional) {
checkConstants(
« no previous file with comments | « pkg/compiler/lib/src/serialization/modelz.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698