Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: tests/compiler/dart2js/serialization_test.dart

Issue 1888393002: Fix some issues in element serialization. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Fix comment. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/compiler/lib/src/serialization/modelz.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.serialization_test; 5 library dart2js.serialization_test;
6 6
7 import 'dart:io'; 7 import 'dart:io';
8 import 'memory_compiler.dart'; 8 import 'memory_compiler.dart';
9 import 'package:async_helper/async_helper.dart'; 9 import 'package:async_helper/async_helper.dart';
10 import 'package:compiler/src/commandline_options.dart'; 10 import 'package:compiler/src/commandline_options.dart';
(...skipping 461 matching lines...) Expand 10 before | Expand all | Expand 10 after
472 element1.sourcePosition, element2.sourcePosition); 472 element1.sourcePosition, element2.sourcePosition);
473 checkTypes( 473 checkTypes(
474 element1, element2, 'type', 474 element1, element2, 'type',
475 element1.type, element2.type); 475 element1.type, element2.type);
476 checkListEquivalence( 476 checkListEquivalence(
477 element1, element2, 'parameters', 477 element1, element2, 'parameters',
478 element1.parameters, element2.parameters, 478 element1.parameters, element2.parameters,
479 checkElementProperties); 479 checkElementProperties);
480 check(element1, element2, 'isOperator', 480 check(element1, element2, 'isOperator',
481 element1.isOperator, element2.isOperator); 481 element1.isOperator, element2.isOperator);
482 check(
483 element1, element2, 'asyncMarker',
484 element1.asyncMarker,
485 element2.asyncMarker);
482 486
483 checkElementIdentities( 487 checkElementIdentities(
484 element1, element2, 'library', 488 element1, element2, 'library',
485 element1.library, element2.library); 489 element1.library, element2.library);
486 checkElementIdentities( 490 checkElementIdentities(
487 element1, element2, 'compilationUnit', 491 element1, element2, 'compilationUnit',
488 element1.compilationUnit, element2.compilationUnit); 492 element1.compilationUnit, element2.compilationUnit);
489 checkElementIdentities( 493 checkElementIdentities(
490 element1, element2, 'enclosingClass', 494 element1, element2, 'enclosingClass',
491 element1.enclosingClass, element2.enclosingClass); 495 element1.enclosingClass, element2.enclosingClass);
496
497 check(
498 element1, element2, 'functionSignature.type',
499 element1.functionSignature.type,
500 element2.functionSignature.type,
501 areTypesEquivalent);
502 checkElementLists(
503 element1, element2, 'functionSignature.requiredParameters',
504 element1.functionSignature.requiredParameters,
505 element2.functionSignature.requiredParameters);
506 checkElementLists(
507 element1, element2, 'functionSignature.optionalParameters',
508 element1.functionSignature.optionalParameters,
509 element2.functionSignature.optionalParameters);
510 check(
511 element1, element2, 'functionSignature.requiredParameterCount',
512 element1.functionSignature.requiredParameterCount,
513 element2.functionSignature.requiredParameterCount);
514 check(
515 element1, element2, 'functionSignature.optionalParameterCount',
516 element1.functionSignature.optionalParameterCount,
517 element2.functionSignature.optionalParameterCount);
518 check(
519 element1, element2, 'functionSignature.optionalParametersAreNamed',
520 element1.functionSignature.optionalParametersAreNamed,
521 element2.functionSignature.optionalParametersAreNamed);
522 check(
523 element1, element2, 'functionSignature.hasOptionalParameters',
524 element1.functionSignature.hasOptionalParameters,
525 element2.functionSignature.hasOptionalParameters);
526 check(
527 element1, element2, 'functionSignature.parameterCount',
528 element1.functionSignature.parameterCount,
529 element2.functionSignature.parameterCount);
530 checkElementLists(
531 element1, element2, 'functionSignature.orderedOptionalParameters',
532 element1.functionSignature.orderedOptionalParameters,
533 element2.functionSignature.orderedOptionalParameters);
492 } 534 }
493 535
494 @override 536 @override
495 void visitConstructorElement(ConstructorElement element1, 537 void visitConstructorElement(ConstructorElement element1,
496 ConstructorElement element2) { 538 ConstructorElement element2) {
497 checkElementIdentities(null, null, null, element1, element2); 539 checkElementIdentities(null, null, null, element1, element2);
498 checkElementIdentities( 540 checkElementIdentities(
499 element1, element2, 'enclosingClass', 541 element1, element2, 'enclosingClass',
500 element1.enclosingClass, element2.enclosingClass); 542 element1.enclosingClass, element2.enclosingClass);
501 check( 543 check(
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
578 element1.sourcePosition, element2.sourcePosition); 620 element1.sourcePosition, element2.sourcePosition);
579 checkTypes( 621 checkTypes(
580 element1, element2, 'type', 622 element1, element2, 'type',
581 element1.type, element2.type); 623 element1.type, element2.type);
582 check( 624 check(
583 element1, element2, 'isOptional', 625 element1, element2, 'isOptional',
584 element1.isOptional, element2.isOptional); 626 element1.isOptional, element2.isOptional);
585 check( 627 check(
586 element1, element2, 'isNamed', 628 element1, element2, 'isNamed',
587 element1.isNamed, element2.isNamed); 629 element1.isNamed, element2.isNamed);
630 check(
631 element1, element2, 'isFinal',
632 element1.isFinal, element2.isFinal);
588 check(element1, element2, 'name', element1.name, element2.name); 633 check(element1, element2, 'name', element1.name, element2.name);
589 if (element1.isOptional) { 634 if (element1.isOptional) {
590 checkConstants( 635 checkConstants(
591 element1, element2, 'constant', 636 element1, element2, 'constant',
592 element1.constant, element2.constant); 637 element1.constant, element2.constant);
593 } 638 }
594 checkElementIdentities( 639 checkElementIdentities(
595 element1, element2, 'compilationUnit', 640 element1, element2, 'compilationUnit',
596 element1.compilationUnit, element2.compilationUnit); 641 element1.compilationUnit, element2.compilationUnit);
597 } 642 }
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
631 void visitPrefixElement(PrefixElement element1, PrefixElement element2) { 676 void visitPrefixElement(PrefixElement element1, PrefixElement element2) {
632 check( 677 check(
633 element1, element2, 'isDeferred', 678 element1, element2, 'isDeferred',
634 element1.isDeferred, element2.isDeferred); 679 element1.isDeferred, element2.isDeferred);
635 checkElementIdentities( 680 checkElementIdentities(
636 element1, element2, 'importedLibrary', 681 element1, element2, 'importedLibrary',
637 element1.deferredImport, element2.deferredImport); 682 element1.deferredImport, element2.deferredImport);
638 // TODO(johnniwinther): Check members. 683 // TODO(johnniwinther): Check members.
639 } 684 }
640 } 685 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/serialization/modelz.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698