Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1888393002: Fix some issues in element serialization. (Closed)

Created:
4 years, 8 months ago by Johnni Winther
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -47 lines) Patch
M pkg/compiler/lib/src/elements/common.dart View 3 chunks +21 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 2 chunks +12 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +0 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 3 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/keys.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 11 chunks +44 lines, -23 lines 0 comments Download
M tests/compiler/dart2js/serialization_test.dart View 3 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 8 months ago (2016-04-15 12:08:42 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 8 months ago (2016-04-15 15:22:43 UTC) #3
Johnni Winther
4 years, 8 months ago (2016-04-18 07:31:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ea4a56251776affe3c449c5c0d0b090edbb61961 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698