Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 1888353003: Revert of clang/win update.py: Put gnuwin last in path. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
hans
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of clang/win update.py: Put gnuwin last in path. (patchset #1 id:1 of https://codereview.chromium.org/1887163003/ ) Reason for revert: Didn't help: Cygwin is in the PATH when ssh'ing in, but not for normal build steps on the bot. Original issue's description: > clang/win update.py: Put gnuwin last in path. > > gnuwin's rm.exe doesn't seem to work with long path names on the bots for some > reason. The bots have cygwin installed and have a better working rm.exe > earlier in the path, so try to use this. (Local devs don't have long paths.) > > BUG=603364 > NOTRY=true > > Committed: https://crrev.com/051cfcb6697da79bd57d47e923505d2ec806cc3a > Cr-Commit-Position: refs/heads/master@{#387463} TBR=hans@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=603364 Committed: https://crrev.com/6678c06e28f094cf1d32d2b4cd723b8bb4cdc48c Cr-Commit-Position: refs/heads/master@{#387595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
Created Revert of clang/win update.py: Put gnuwin last in path.
4 years, 8 months ago (2016-04-15 14:15:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888353003/1
4 years, 8 months ago (2016-04-15 14:15:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 14:16:02 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 14:18:07 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6678c06e28f094cf1d32d2b4cd723b8bb4cdc48c
Cr-Commit-Position: refs/heads/master@{#387595}

Powered by Google App Engine
This is Rietveld 408576698