x64: Decode more objects for code view.

x64: Decode more objects for code view.

In particular, the cmpq for parsing named optional arguments has the
object recognized.

BUG=
R=fschneider@google.com, johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/d57599e6d114629eae4f1a78487c2c69ea0a393c

[sra1, 2016-04-15 05:53:16]

sra@google.com changed reviewers:
+ johnmccutchan@google.com

[sra1, 2016-04-15 05:53:17]

WDYT?

[Cutch, 2016-04-15 13:58:46]

On 2016/04/15 05:53:17, sra1 wrote:
> WDYT?

What about other architectures?

[sra1, 2016-04-15 16:09:22]

On 2016/04/15 13:58:46, Cutch wrote:
> On 2016/04/15 05:53:17, sra1 wrote:
> > WDYT?
> 
> What about other architectures?

I see this as a bugfix for x64 movq/cmpq rA,[rB+delta] where some only 'random'
subset of values of rA were decoded.

ia32 has no decoding at all.
I have never looked at the observatory decoding of mips and arm, so I don't know
if they are incomplete.

[Florian Schneider, 2016-04-15 16:57:49]

fschneider@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-04-15 16:57:50]

I think it's good to fix the x64 code.

ARM has other issues that not related to this CL.

https://codereview.chromium.org/1888353002/diff/1/runtime/vm/instructions_x64.cc
File runtime/vm/instructions_x64.cc (right):

https://codereview.chromium.org/1888353002/diff/1/runtime/vm/instructions_x64...
runtime/vm/instructions_x64.cc:54: if ((bytes[2] & 0xc7) == (0x40 | (R14 & 7)))
{
s/R14/THR/g for consistency with PP above.

Maybe also reorder, and check for disp32 first.

https://codereview.chromium.org/1888353002/diff/1/runtime/vm/instructions_x64...
runtime/vm/instructions_x64.cc:55: // [r14+disp8]
Move to prev line.

https://codereview.chromium.org/1888353002/diff/1/runtime/vm/instructions_x64...
runtime/vm/instructions_x64.cc:59: if ((bytes[2] & 0307) == (0x80 | (R14 & 7)))
{
Please don't use octal literals...

if ((bytes[2] & 0xc7) == (0x80 | (THR & 7))) {

[sra1, 2016-04-15 17:55:00]

PTAL

https://codereview.chromium.org/1888353002/diff/1/runtime/vm/instructions_x64.cc
File runtime/vm/instructions_x64.cc (right):

https://codereview.chromium.org/1888353002/diff/1/runtime/vm/instructions_x64...
runtime/vm/instructions_x64.cc:54: if ((bytes[2] & 0xc7) == (0x40 | (R14 & 7)))
{
On 2016/04/15 16:57:49, Florian Schneider wrote:
> s/R14/THR/g for consistency with PP above.
> 
> Maybe also reorder, and check for disp32 first.

Done.

https://codereview.chromium.org/1888353002/diff/1/runtime/vm/instructions_x64...
runtime/vm/instructions_x64.cc:55: // [r14+disp8]
On 2016/04/15 16:57:49, Florian Schneider wrote:
> Move to prev line.

Done.

https://codereview.chromium.org/1888353002/diff/1/runtime/vm/instructions_x64...
runtime/vm/instructions_x64.cc:59: if ((bytes[2] & 0307) == (0x80 | (R14 & 7)))
{
On 2016/04/15 16:57:49, Florian Schneider wrote:
> Please don't use octal literals...
> 
> if ((bytes[2] & 0xc7) == (0x80 | (THR & 7))) {

Done. I missed that one. (mod r/m fields correspond to octal digits).

https://codereview.chromium.org/1888353002/diff/1/runtime/vm/instructions_x64...
runtime/vm/instructions_x64.cc:59: if ((bytes[2] & 0307) == (0x80 | (R14 & 7)))
{
On 2016/04/15 16:57:49, Florian Schneider wrote:
> Please don't use octal literals...
> 
> if ((bytes[2] & 0xc7) == (0x80 | (THR & 7))) {

Done.

[Florian Schneider, 2016-04-15 18:17:00]

lgtm

[Cutch, 2016-04-15 18:17:37]

lgtm

[sra1, 2016-04-15 19:19:21]

Description was changed from

==========
x64: Decode more objects for code view.

In particular, the cmpq for parsing named optional arguments has the
object recognized.

BUG=
==========

to

==========
x64: Decode more objects for code view.

In particular, the cmpq for parsing named optional arguments has the
object recognized.

BUG=
R=fschneider@google.com, johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d57599e6d114629eae4f1a78487c2c69ea0a393c
==========

[sra1, 2016-04-15 19:19:22]

Committed patchset #2 (id:20001) manually as
d57599e6d114629eae4f1a78487c2c69ea0a393c.