Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1888343002: Mac: Honour the user preference for triggering QuickLook with Force Click (Closed)

Created:
4 years, 8 months ago by tapted
Modified:
4 years, 8 months ago
Reviewers:
ccameron
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Honour the user preference for triggering QuickLook with Force Click Chrome maps force click to Quick Look in the content area since r368481 but a user preference should override that. Dumping out +[NSUserDefaults standardUserDefaults] after toggling the setting in the Touchpad System Preferences pane reveals that this info is stored in "com.apple.trackpad.forceClick". Obey. BUG=602382 Committed: https://crrev.com/fbc03c43bcc3d9635d9203685538231c11eec5b8 Cr-Commit-Position: refs/heads/master@{#387838}

Patch Set 1 : be explicit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +3 lines, -1 line 0 comments Download
M ui/base/cocoa/appkit_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/cocoa/appkit_utils.mm View 3 chunks +20 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
tapted
Hi Chris, please take a look
4 years, 8 months ago (2016-04-15 04:47:23 UTC) #6
ccameron
obeying lgtm
4 years, 8 months ago (2016-04-15 17:05:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888343002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888343002/60001
4 years, 8 months ago (2016-04-18 00:00:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 8 months ago (2016-04-18 00:38:51 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 00:40:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbc03c43bcc3d9635d9203685538231c11eec5b8
Cr-Commit-Position: refs/heads/master@{#387838}

Powered by Google App Engine
This is Rietveld 408576698