Issue 1888333002: Prevent cloned arrays/dictionaries from having nullptrs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1888333002: Prevent cloned arrays/dictionaries from having nullptrs. (Closed)

Created:
4 years, 8 months ago by Lei Zhang

Modified:
4 years, 3 months ago

Reviewers:
Wei Li

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Prevent cloned arrays/dictionaries from having nullptrs. BUG=597440

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	core/fpdfapi/fpdf_parser/cpdf_array.cpp	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Lei Zhang

WDYT? The other possibility is to tolerate nullptrs in arrays/dictionaries and check for them everywhere.

4 years, 8 months ago (2016-04-15 02:15:21 UTC) #2

Wei Li

On 2016/04/15 02:15:21, Lei Zhang wrote: > WDYT? The other possibility is to tolerate nullptrs ...

4 years, 8 months ago (2016-04-15 18:05:48 UTC) #3

Message was sent while issue was closed.

Abandoning. Let's start over.