Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issue 1888323002: Remove GLContextStub::GetExtensions. (Closed)

Created:
4 years, 8 months ago by danakj
Modified:
4 years, 8 months ago
CC:
chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GLContextStub::GetExtensions. This method overrides GLContext::GetExtensions. The GLContext method will simply call glGetString(GL_EXTENSIONS), which is normally what you want do to. The GLContextStub overrides this method to return an empty string, which means that you are unable to change what extensions will be returned by glGetString. There is also a GLContextStubWithExtensions, which overrides GetExtensions again, providing a way to set the string returned from GLContext, as well as a version string, but then these strings no longer match what the calls to glGetString would return, so this isn't something I want to use in my new test. Instead allow GLContextStub to be used with an extensions string returned from glGetString of my choosing. R=kbr@chromium.org, piman, sievers BUG=584497 Committed: https://crrev.com/06a9b07727f9548cc408ca9c12a59442d4096254 Cr-Commit-Position: refs/heads/master@{#387524}

Patch Set 1 : stub #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M ui/gl/gl_context_stub.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_context_stub.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888323002/1
4 years, 8 months ago (2016-04-15 01:29:01 UTC) #4
danakj
Im not sure if there's tests that depend on this.. fishing now.
4 years, 8 months ago (2016-04-15 01:29:48 UTC) #5
piman
LGTM if tests pass.
4 years, 8 months ago (2016-04-15 02:00:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888323002/1
4 years, 8 months ago (2016-04-15 02:22:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 02:26:13 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 02:30:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06a9b07727f9548cc408ca9c12a59442d4096254
Cr-Commit-Position: refs/heads/master@{#387524}

Powered by Google App Engine
This is Rietveld 408576698