Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1888223003: Move scopes into a separate library (Closed)

Created:
4 years, 8 months ago by Brian Wilkerson
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1138 lines, -1206 lines) Patch
M pkg/analysis_server/lib/src/services/correction/namespace.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analyzer/lib/src/dart/resolver/scope.dart View 1 chunk +1069 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 12 chunks +68 lines, -1204 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Aside from some comment clean-up (and cleaning up one hint missed in an earlier CL), ...
4 years, 8 months ago (2016-04-15 04:06:56 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-04-15 04:08:08 UTC) #3
Brian Wilkerson
4 years, 8 months ago (2016-04-15 14:38:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d680aba41537870c9eb3327a463c08e47ea26600 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698