Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1888203002: Adds logging code to help figure out why test is crashing on bot (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
Reviewers:
msw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds logging code to help figure out why test is crashing on bot Test is timing out with error of -1. I can't repro locally, so I'm hoping this will shed some light on how far things are getting. BUG=594600 TEST=none R=msw@chromium.org Committed: https://crrev.com/f24fa9e0a4869c45515161d24a5c4086b648fe2b Cr-Commit-Position: refs/heads/master@{#387438}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/test/base/mash_browser_tests_main.cc View 2 chunks +2 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
sky
4 years, 8 months ago (2016-04-14 21:17:16 UTC) #1
msw
lgtm with an optional nit https://codereview.chromium.org/1888203002/diff/1/chrome/test/base/mash_browser_tests_main.cc File chrome/test/base/mash_browser_tests_main.cc (right): https://codereview.chromium.org/1888203002/diff/1/chrome/test/base/mash_browser_tests_main.cc#newcode133 chrome/test/base/mash_browser_tests_main.cc:133: LOG(ERROR) << "child exit_code=" ...
4 years, 8 months ago (2016-04-14 21:29:41 UTC) #2
sky
I'm going to land as is. Will remove shortly.
4 years, 8 months ago (2016-04-14 21:30:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888203002/1
4 years, 8 months ago (2016-04-14 21:31:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 21:53:05 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 21:54:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f24fa9e0a4869c45515161d24a5c4086b648fe2b
Cr-Commit-Position: refs/heads/master@{#387438}

Powered by Google App Engine
This is Rietveld 408576698